From: Mark Salter <msalter@redhat.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Linaro Patches <patches@linaro.org>,
Will Deacon <will.deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/5] arm64: add early_ioremap support
Date: Wed, 05 Mar 2014 11:38:44 -0500 [thread overview]
Message-ID: <1394037524.5094.35.camel@deneb.redhat.com> (raw)
In-Reply-To: <CAL_JsqLQ8gj4nkwh+67i58rQBARoh_CgZ+4D9uepdBQm-XBwJA@mail.gmail.com>
On Tue, 2014-03-04 at 17:31 -0600, Rob Herring wrote:
> On Tue, Mar 4, 2014 at 2:08 PM, Mark Salter <msalter@redhat.com> wrote:
> > Add support for early IO or memory mappings which are needed
> > before the normal ioremap() is usable. This also adds fixmap
> > support for permanent fixed mappings such as that used by the
> > earlyprintk device register region.
>
> One minor comment:
>
> > +enum fixed_addresses {
> > + FIX_EARLYCON,
>
> Can you align this name with x86 and rename to FIX_EARLYCON_MEM_BASE.
> Doing that will help enable the earlycon driver in 8250_early.c.
Is there any advantage to earlycon=uart8250 vs. earlyprintk=uart8250?
I don't mind using FIX_EARLYCON_MEM_BASE, but CONFIG_FIX_EARLYCON_MEM
is X86 only right now and I think changing that should be a separate
patch.
next prev parent reply other threads:[~2014-03-05 16:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 20:08 [PATCH 0/5] mm: generic " Mark Salter
2014-03-04 20:08 ` [PATCH 1/5] x86/mm: sparse warning fix for early_memremap Mark Salter
2014-03-04 20:08 ` [PATCH 2/5] mm: create generic early_ioremap() support Mark Salter
2014-03-05 22:29 ` Andrew Morton
2014-03-06 21:25 ` Mark Salter
2014-03-04 20:08 ` [PATCH 3/5] x86: use generic early_ioremap Mark Salter
2014-03-04 20:08 ` [PATCH 4/5] arm64: initialize pgprot info earlier in boot Mark Salter
2014-03-04 20:08 ` [PATCH 5/5] arm64: add early_ioremap support Mark Salter
2014-03-04 23:31 ` Rob Herring
2014-03-05 16:38 ` Mark Salter [this message]
2014-03-06 8:20 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394037524.5094.35.camel@deneb.redhat.com \
--to=msalter@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=robherring2@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome