mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org, alex.williamson@redhat.com,
	mtosatti@redhat.com, gleb@kernel.org, jan.kiszka@siemens.com
Subject: [PATCH 0/7] KVM: x86: Let the guest write to multiple debug registers with one vmexit
Date: Fri,  7 Mar 2014 12:42:44 +0100	[thread overview]
Message-ID: <1394192571-11056-1-git-send-email-pbonzini@redhat.com> (raw)

Alex Williamson reported that a Windows game does something weird that
makes the guest save and restore debug registers on each context switch.
This cause several hundred thousands vmexits per second, and basically
cuts performance in half when running under KVM.

However, when not running in guest-debug mode, the guest controls the
debug registers and having to take an exit for each DR access is a waste
of time.  We just need one vmexit to load any stale values of DR0-DR6,
and then we can let the guest run freely.  On the next vmexit (whatever
the reason) we will read out whatever changes the guest made to the
debug registers.

Tested with x86/debug.flat on both Intel and AMD, both direct and
nested virtualization.

Changes from RFC: changed get_dr7 callback to sync_dirty_debug_regs,
	new patches 5-7.

Paolo Bonzini (7):
  KVM: vmx: we do rely on loading DR7 on entry
  KVM: x86: change vcpu->arch.switch_db_regs to a bit mask
  KVM: x86: Allow the guest to run with dirty debug registers
  KVM: vmx: Allow the guest to run with dirty debug registers
  KVM: nVMX: Allow nested guests to run with dirty debug registers
  KVM: svm: set/clear all DR intercepts in one swoop
  KVM: svm: Allow the guest to run with dirty debug registers

 arch/x86/include/asm/kvm_host.h |  8 ++++-
 arch/x86/kvm/svm.c              | 68 ++++++++++++++++++++++++++++-------------
 arch/x86/kvm/vmx.c              | 43 ++++++++++++++++++++++++--
 arch/x86/kvm/x86.c              | 20 +++++++++++-
 4 files changed, 114 insertions(+), 25 deletions(-)

-- 
1.8.3.1


             reply	other threads:[~2014-03-07 11:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-07 11:42 Paolo Bonzini [this message]
2014-03-07 11:42 ` [PATCH 1/7] KVM: vmx: we do rely on loading DR7 on entry Paolo Bonzini
2014-03-07 11:42 ` [PATCH 2/7] KVM: x86: change vcpu->arch.switch_db_regs to a bit mask Paolo Bonzini
2014-03-07 11:42 ` [PATCH 3/7] KVM: x86: Allow the guest to run with dirty debug registers Paolo Bonzini
2014-03-09 18:28   ` Radim Krčmář
2014-03-09 20:07     ` Paolo Bonzini
2014-03-10 12:11       ` Radim Krčmář
2014-03-07 11:42 ` [PATCH 4/7] KVM: vmx: " Paolo Bonzini
2014-03-09 18:26   ` Radim Krčmář
2014-03-09 20:12     ` Paolo Bonzini
2014-03-10 12:17       ` Radim Krčmář
2014-03-10 12:24         ` Paolo Bonzini
2014-03-07 11:42 ` [PATCH 5/7] KVM: nVMX: Allow nested guests " Paolo Bonzini
2014-03-07 11:42 ` [PATCH 6/7] KVM: svm: set/clear all DR intercepts in one swoop Paolo Bonzini
2014-03-07 11:42 ` [PATCH 7/7] KVM: svm: Allow the guest to run with dirty debug registers Paolo Bonzini
2014-03-09  8:11 ` [PATCH 0/7] KVM: x86: Let the guest write to multiple debug registers with one vmexit Jan Kiszka
2014-03-09  8:15   ` Jan Kiszka
2014-03-09  8:31     ` Paolo Bonzini
2014-03-10 12:23 ` Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394192571-11056-1-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=gleb@kernel.org \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®