From: Joe Perches <joe@perches.com>
To: behanw@converseincode.com
Cc: khali@linux-fr.org, rostedt@goodmis.org, rusty@rustcorp.com.au,
linux-kernel@vger.kernel.org, dwmw2@infradead.org,
pageexec@freemail.hu, Mark Charlebois <charlebm@gmail.com>
Subject: Re: [PATCH v2] module: LLVMLinux: Remove unused function warning from __param_check macro
Date: Fri, 07 Mar 2014 18:17:54 -0800 [thread overview]
Message-ID: <1394245074.6972.7.camel@joe-AO722> (raw)
In-Reply-To: <1394244623-25623-1-git-send-email-behanw@converseincode.com>
On Fri, 2014-03-07 at 18:10 -0800, behanw@converseincode.com wrote:
> This code makes a compile time type check that is optimized away. Clang
> complains that it generates an unused function.
[]
> diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h
[]
> @@ -346,7 +346,7 @@ static inline void destroy_params(const struct kernel_param *params,
> /* The macros to do compile-time type checking stolen from Jakub
> Jelinek, who IIRC came up with this idea for the 2.4 module init code. */
> #define __param_check(name, p, type) \
> - static inline type *__check_##name(void) { return(p); }
> + static inline __always_unused type *__check_##name(void) { return(p); }
Perhaps __maybe_unused ?
next prev parent reply other threads:[~2014-03-08 2:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 19:08 [PATCH] " behanw
2014-03-07 22:56 ` PaX Team
2014-03-08 0:52 ` Behan Webster
2014-03-08 1:25 ` PaX Team
2014-03-08 1:35 ` Stephen Boyd
2014-03-08 2:10 ` [PATCH v2] " behanw
2014-03-08 2:17 ` Joe Perches [this message]
2014-03-08 2:21 ` Behan Webster
2014-03-11 6:11 ` [PATCH] " Rusty Russell
2014-03-11 7:00 ` Behan Webster
2014-03-11 21:24 ` [PATCH v3] " behanw
2014-03-17 2:47 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394245074.6972.7.camel@joe-AO722 \
--to=joe@perches.com \
--cc=behanw@converseincode.com \
--cc=charlebm@gmail.com \
--cc=dwmw2@infradead.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pageexec@freemail.hu \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®