From: Paul Bolle <pebolle@tiscali.nl>
To: Andy Lutomirski <luto@amacapital.net>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org,
Chris Metcalf <cmetcalf@tilera.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Ken Steele <ken@tilera.com>, Nicolas Pitre <nico@linaro.org>
Subject: Re: [PATCH 4/4] raid6: Add severity levels to raid6 initialization messages
Date: Sat, 08 Mar 2014 20:14:33 +0100 [thread overview]
Message-ID: <1394306073.32104.4.camel@x220> (raw)
In-Reply-To: <16072d10240583debb7d303136c507c32c4d4b5d.1394304585.git.luto@amacapital.net>
On Sat, 2014-03-08 at 10:58 -0800, Andy Lutomirski wrote:
> Some of them are errors; some are not. Annotate them accordingly.
>
> Signed-off-by: Andy Lutomirski <luto@amacapital.net>
> ---
> lib/raid6/algos.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/lib/raid6/algos.c b/lib/raid6/algos.c
> [...]
> @@ -194,7 +195,7 @@ int __init raid6_select_algo(void)
> syndromes = (void *) __get_free_pages(GFP_KERNEL, 1);
>
> if (!syndromes) {
> - printk("raid6: Yikes! No memory available.\n");
> + printk(KERN_ERR "raid6: Yikes! No memory available.\n");
> return -ENOMEM;
> }
>
Does __get_free_pages() print and error (or similar) when it fails? If
so, this printk() could be dropped, couldn't it?
Paul Bolle
next prev parent reply other threads:[~2014-03-08 19:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-08 18:58 [PATCH 0/4] Fix some spurious errors at bootup Andy Lutomirski
2014-03-08 18:58 ` [PATCH 1/4] mei: Don't log an error when the MEI device is quirked off Andy Lutomirski
2014-03-11 10:03 ` Winkler, Tomas
2014-03-11 22:17 ` Andy Lutomirski
2014-03-11 22:33 ` Winkler, Tomas
2014-03-08 18:58 ` [PATCH 2/4] megaraid: Downgrade success messages from KERN_ERR to dev_dbg Andy Lutomirski
2014-03-08 18:58 ` [PATCH 3/4] sr: Add a missing KERN_INFO Andy Lutomirski
2014-03-08 18:58 ` [PATCH 4/4] raid6: Add severity levels to raid6 initialization messages Andy Lutomirski
2014-03-08 19:14 ` Paul Bolle [this message]
2014-03-11 22:22 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394306073.32104.4.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=ard.biesheuvel@linaro.org \
--cc=cmetcalf@tilera.com \
--cc=ken@tilera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=nico@linaro.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®