From: Paul Bolle <pebolle@tiscali.nl>
To: Lennox Wu <lennox.wu@gmail.com>
Cc: Michael Opdenacker <michael.opdenacker@free-electrons.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [RESEND] score: remove unused CPU_SCORE7 Kconfig parameter
Date: Sat, 08 Mar 2014 22:02:14 +0100 [thread overview]
Message-ID: <1394312534.2040.18.camel@x220> (raw)
In-Reply-To: <CAF0htA7TeuKjQzU9EE5_RWUkznf+Xp=CsGd=TA6qB0COQxUYQg@mail.gmail.com>
On Sun, 2014-03-09 at 04:27 +0800, Lennox Wu wrote:
> 2014-03-09 4:00 GMT+08:00 Paul Bolle <pebolle@tiscali.nl>:
> > In https://lkml.org/lkml/2011/11/12/76 I already reported that this
> > Kconfig symbol was unused. Why can't it be dropped and re-added when
> > code is added to the tree that actually uses it?
>
> Because I don't think droping it is meaningful, since it will be used.
But, again, it isn't used now and hasn't actually been used in years.
> Moreover, the symbol never affect other architectures or subsystems.
> I feel that is not good to brother people to process the unimportant patch.
Sure, this is just a small cleanup. But the scripts people use to see
whether more serious Kconfig related issues have entered the tree will
likely notice CPU_SCORE7. (And those people will have to investigate why
that symbol is unused - which might take quite a bit of work - to
determine what needs to be done about it.) So whenever someone, not
following this thread, runs a script like that the score maintainers
might receive a similar patch again.
And I don't believe that handling a single cleanup patch is particularly
burdensome for the score maintainers.
Paul Bolle
next prev parent reply other threads:[~2014-03-08 21:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 9:58 [PATCH] " Michael Opdenacker
2013-11-04 14:52 ` Lennox Wu
2013-11-04 15:03 ` Michael Opdenacker
2013-12-09 5:33 ` [PATCH][RESEND] " Michael Opdenacker
2014-03-08 5:26 ` [PATCH] [RESEND] " Michael Opdenacker
2014-03-08 6:34 ` Lennox Wu
2014-03-08 20:00 ` Paul Bolle
2014-03-08 20:27 ` Lennox Wu
2014-03-08 21:02 ` Paul Bolle [this message]
2014-03-09 5:33 ` Lennox Wu
2014-03-10 8:45 ` Michael Opdenacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394312534.2040.18.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=lennox.wu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.opdenacker@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®