mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chase Southwood <chase.southwood@yahoo.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"abbotti@mev.co.uk" <abbotti@mev.co.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] Staging: comedi: convert while loops to timeouts in
Date: Sat, 8 Mar 2014 19:55:57 -0800 (PST)	[thread overview]
Message-ID: <1394337357.59397.YahooMailNeo@web164002.mail.gq1.yahoo.com> (raw)
In-Reply-To: <20140309030056.GA10867@kroah.com>

Hi Greg,

>On Saturday, March 8, 2014 9:00 PM, Greg KH <gregkh@linuxfoundation.org> wrote:

>>On Fri, Mar 07, 2014 at 07:43:04PM -0600, Chase Southwood wrote:
>>This patch changes a handful of while loops to timeouts to prevent
>>infinite looping on hardware failure. A couple such loops are in a
>>function (s626_debi_transfer()) which is called from critical sections,
>>so comedi_timeout() is unusable for them, and an iterative timeout is
>>used instead. For the while loops in a context where comedi_timeout() is
>>allowed, a new callback function, s626_send_dac_eoc(), has been defined
>>to evaluate the conditions that the while loops are testing.  The new
>>callback employs a switch statement based on a simple new enum so that
>>it is usable for all of the different conditions tested in while loops
>>in s626_send_dac().  The proper comedi_timeout() calls are then used.
>
>Your subject seems to be missing a word at the end of it :(

Well what a silly problem to have :( I don't know what happened there
but I'll fix the subject and send it out again.

Thanks,
Chase

  reply	other threads:[~2014-03-09  3:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28  7:35 [PATCH] Staging: comedi: add timeouts to while loops in s626.c Chase Southwood
2014-02-28 17:18 ` Ian Abbott
2014-03-01  5:48   ` Chase Southwood
2014-03-02  4:13     ` Chase Southwood
2014-03-03 14:13       ` Ian Abbott
2014-03-04  4:06         ` Chase Southwood
2014-03-03 14:05     ` Ian Abbott
2014-03-04  8:43 ` [PATCH v2 1/2] Staging: comedi: convert while loops to timeouts " Chase Southwood
2014-03-05 12:09   ` Ian Abbott
2014-03-06  8:13     ` Chase Southwood
2014-03-08  1:43   ` [PATCH v3 1/2] Staging: comedi: convert while loops to timeouts in Chase Southwood
2014-03-09  3:00     ` Greg KH
2014-03-09  3:55       ` Chase Southwood [this message]
2014-03-09  4:00       ` [PATCH v3 1/2] Staging: comedi: convert while loops to timeouts in s626.c Chase Southwood
2014-03-11 14:26         ` Ian Abbott
2014-03-15  1:43           ` Chase Southwood
2014-03-15  5:26             ` gregkh
2014-03-15  7:18               ` Chase Southwood
2014-03-08  1:43   ` [PATCH v3 2/2] Staging: comedi: propagate timeout errors " Chase Southwood
2014-03-11 14:27     ` Ian Abbott
2014-03-04  8:44 ` [PATCH v2 " Chase Southwood
2014-03-05 12:11   ` Ian Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394337357.59397.YahooMailNeo@web164002.mail.gq1.yahoo.com \
    --to=chase.southwood@yahoo.com \
    --cc=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®