From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Daniel Borkmann <dborkman@redhat.com>,
Ingo Molnar <mingo@kernel.org>, Will Drewry <wad@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
"H. Peter Anvin" <hpa@zytor.com>,
Hagen Paul Pfeifer <hagen@jauu.net>,
Jesse Gross <jesse@nicira.com>,
Thomas Gleixner <tglx@linutronix.de>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Jovi Zhangwei <jovi.zhangwei@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Pekka Enberg <penberg@iki.fi>,
Arjan van de Ven <arjan@infradead.org>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v7 net-next 1/3] filter: add Extended BPF interpreter and converter
Date: Sun, 09 Mar 2014 07:45:53 -0700 [thread overview]
Message-ID: <1394376353.20149.96.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <1394320530-3508-2-git-send-email-ast@plumgrid.com>
On Sat, 2014-03-08 at 15:15 -0800, Alexei Starovoitov wrote:
> +/**
> + * sk_run_filter_ext - run an extended filter
> + * @ctx: buffer to run the filter on
> + * @insn: filter to apply
> + *
> + * Decode and execute extended BPF instructions.
> + * @ctx is the data we are operating on.
> + * @filter is the array of filter instructions.
> + */
> +notrace u32 sk_run_filter_ext(void *ctx, const struct sock_filter_ext *insn)
> +{
> + u64 stack[64];
> + u64 regs[16];
> + void *ptr;
> + u64 tmp;
> + int off;
Why is this 'notrace' ?
80 u64 on the stack, that is 640 bytes to run a filter ????
next prev parent reply other threads:[~2014-03-09 14:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-08 23:15 [PATCH v7 net-next 0/3] filter: add Extended BPF interpreter and converter, seccomp Alexei Starovoitov
2014-03-08 23:15 ` [PATCH v7 net-next 1/3] filter: add Extended BPF interpreter and converter Alexei Starovoitov
2014-03-09 12:29 ` Daniel Borkmann
2014-03-09 17:08 ` Alexei Starovoitov
2014-03-09 22:00 ` Daniel Borkmann
2014-03-10 0:41 ` Alexei Starovoitov
2014-03-11 17:40 ` Pavel Emelyanov
2014-03-11 18:03 ` Alexei Starovoitov
2014-03-11 18:19 ` Pavel Emelyanov
2014-03-09 14:45 ` Eric Dumazet [this message]
2014-03-09 17:38 ` Alexei Starovoitov
2014-03-09 18:11 ` Eric Dumazet
2014-03-09 18:57 ` Alexei Starovoitov
2014-03-09 19:11 ` Eric Dumazet
2014-03-09 19:20 ` Alexei Starovoitov
2014-03-09 14:49 ` Eric Dumazet
2014-03-09 18:02 ` Alexei Starovoitov
2014-03-08 23:15 ` [PATCH v7 net-next 2/3] seccomp: convert seccomp to use extended BPF Alexei Starovoitov
2014-03-08 23:15 ` [PATCH v7 net-next 3/3] doc: filter: add Extended BPF documentation Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394376353.20149.96.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=hagen@jauu.net \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=jesse@nicira.com \
--cc=jovi.zhangwei@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=penberg@iki.fi \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tom.zanussi@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®