mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	Namhyung Kim <namhyung@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>
Subject: [PATCH 7/9] perf tools: Add hist.percentage config option
Date: Mon, 10 Mar 2014 16:43:58 +0900	[thread overview]
Message-ID: <1394437440-11609-8-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1394437440-11609-1-git-send-email-namhyung@kernel.org>

Add hist.percentage option for setting default value of the
symbol_conf.filter_relative.  It affects the output of various perf
commands (like perf report, top and diff) only if filter(s) applied.

An user can write .perfconfig file like below to show absolute
percentage of filtered entries by default:

  $ cat ~/.perfconfig
  [hist]
  percentage = absolute

And it can be changed through command line:

  $ perf report --percentage relative

Acked-by: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/builtin-diff.c | 2 ++
 tools/perf/util/config.c  | 4 ++++
 tools/perf/util/hist.c    | 8 ++++++++
 tools/perf/util/hist.h    | 1 +
 4 files changed, 15 insertions(+)

diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index c903fe13c173..6ef80f22c1e2 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -1134,6 +1134,8 @@ static int data_init(int argc, const char **argv)
 
 int cmd_diff(int argc, const char **argv, const char *prefix __maybe_unused)
 {
+	perf_config(perf_default_config, NULL);
+
 	sort_order = diff__default_sort_order;
 	argc = parse_options(argc, argv, options, diff_usage, 0);
 
diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
index 3e0fdd369ccb..24519e14ac56 100644
--- a/tools/perf/util/config.c
+++ b/tools/perf/util/config.c
@@ -11,6 +11,7 @@
 #include "util.h"
 #include "cache.h"
 #include "exec_cmd.h"
+#include "util/hist.h"  /* perf_hist_config */
 
 #define MAXNAME (256)
 
@@ -355,6 +356,9 @@ int perf_default_config(const char *var, const char *value,
 	if (!prefixcmp(var, "core."))
 		return perf_default_core_config(var, value);
 
+	if (!prefixcmp(var, "hist."))
+		return perf_hist_config(var, value);
+
 	/* Add other config variables here. */
 	return 0;
 }
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index 6e7eb53d4bcc..a0b32df4cd88 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -956,3 +956,11 @@ int parse_filter_percentage(const struct option *opt __maybe_unused,
 
 	return 0;
 }
+
+int perf_hist_config(const char *var, const char *value)
+{
+	if (!strcmp(var, "hist.percentage"))
+		return parse_filter_percentage(NULL, value, 0);
+
+	return 0;
+}
diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h
index a4ec336ae3fe..5a0343eb22e2 100644
--- a/tools/perf/util/hist.h
+++ b/tools/perf/util/hist.h
@@ -258,5 +258,6 @@ unsigned int hists__sort_list_width(struct hists *hists);
 struct option;
 int parse_filter_percentage(const struct option *opt __maybe_unused,
 			    const char *arg, int unset __maybe_unused);
+int perf_hist_config(const char *var, const char *value);
 
 #endif	/* __PERF_HIST_H */
-- 
1.7.11.7


  parent reply	other threads:[~2014-03-10  7:45 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10  7:43 [PATCHSET 0/9] perf tools: Update on filtered entries' percentage output (v7) Namhyung Kim
2014-03-10  7:43 ` [PATCH 1/9] perf tools: Pass evsel to hpp->header/width functions explicitly Namhyung Kim
2014-03-18  8:30   ` [tip:perf/core] perf ui hists: Pass evsel to hpp->header/ width " tip-bot for Namhyung Kim
2014-03-10  7:43 ` [PATCH 2/9] perf tools: Count periods of filtered entries separately Namhyung Kim
2014-03-17 20:08   ` Arnaldo Carvalho de Melo
2014-03-18  4:19     ` Namhyung Kim
2014-03-18  4:25       ` Namhyung Kim
2014-03-18 13:15       ` Arnaldo Carvalho de Melo
2014-03-18 13:18         ` Arnaldo Carvalho de Melo
2014-03-18 14:11           ` Namhyung Kim
2014-03-10  7:43 ` [PATCH 3/9] perf hists: Add support for showing relative percentage Namhyung Kim
2014-03-18 20:08   ` Arnaldo Carvalho de Melo
2014-03-19  0:18     ` Namhyung Kim
2014-03-19 20:25       ` Arnaldo Carvalho de Melo
2014-03-10  7:43 ` [PATCH 4/9] perf report: Add --percentage option Namhyung Kim
2014-03-10  7:43 ` [PATCH 5/9] perf top: " Namhyung Kim
2014-03-10  7:43 ` [PATCH 6/9] perf diff: " Namhyung Kim
2014-03-10  7:43 ` Namhyung Kim [this message]
2014-03-10  7:43 ` [PATCH 8/9] perf ui/tui: Add 'F' hotkey to toggle percentage output Namhyung Kim
2014-03-10  7:44 ` [PATCH 9/9] perf tools: Show absolute percentage by default Namhyung Kim
2014-03-10 22:08 ` [PATCHSET 0/9] perf tools: Update on filtered entries' percentage output (v7) Andi Kleen
2014-03-11  2:58   ` Davidlohr Bueso
2014-03-11  2:59     ` Davidlohr Bueso
2014-03-11  7:57     ` Namhyung Kim
2014-03-11  7:45   ` Namhyung Kim
2014-03-17  8:05 ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394437440-11609-8-git-send-email-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=andi@firstfloor.org \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®