From: Joe Perches <joe@perches.com>
To: Dirk Brandewie <dirk.brandewie@gmail.com>
Cc: Soren Brinkmann <soren.brinkmann@xilinx.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
cpufreq@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v2] cpufreq: Reformat printk() statements
Date: Tue, 11 Mar 2014 10:16:52 -0700 [thread overview]
Message-ID: <1394558212.21085.57.camel@joe-AO722> (raw)
In-Reply-To: <531F441C.5070107@gmail.com>
On Tue, 2014-03-11 at 10:13 -0700, Dirk Brandewie wrote:
> On 03/11/2014 10:03 AM, Soren Brinkmann wrote:
> > From: Joe Perches <joe@perches.com>
> > - Add missing newlines
> > - Coalesce format fragments
> > - Convert printks to pr_<level>
> > - Align arguments
> This introduces a bunch of lines over 80 charaters long.
Intentionally.
from: Documentation/CodingStyle
Chapter 2: Breaking long lines and strings
Coding style is all about readability and maintainability using commonly
available tools.
[]
never break user-visible strings such as
printk messages, because that breaks the ability to grep for them.
next prev parent reply other threads:[~2014-03-11 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 17:03 Soren Brinkmann
2014-03-11 17:13 ` Dirk Brandewie
2014-03-11 17:15 ` Sören Brinkmann
2014-03-11 17:16 ` Joe Perches [this message]
2014-03-11 19:29 ` Rafael J. Wysocki
2014-03-11 19:15 ` Dirk Brandewie
2014-03-11 19:51 ` Rafael J. Wysocki
2014-03-12 0:12 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394558212.21085.57.camel@joe-AO722 \
--to=joe@perches.com \
--cc=cpufreq@vger.kernel.org \
--cc=dirk.brandewie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=soren.brinkmann@xilinx.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®