mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: tglx@linutronix.de, mingo@kernel.org
Cc: linux-kernel@vger.kernel.org, dan.carpenter@oracle.com,
	ezequiel.garcia@free-electrons.com, ivan.khoronzhuk@ti.com,
	linus.walleij@linaro.org, magnus.damm@gmail.com,
	matthias.bgg@gmail.com, soren.brinkmann@xilinx.com,
	sboyd@codeaurora.org
Subject: [PATCH 09/17] clocksource: armada-370-xp: Use atomic access for shared registers
Date: Tue, 11 Mar 2014 23:40:45 +0100	[thread overview]
Message-ID: <1394577653-8615-9-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1394577653-8615-1-git-send-email-daniel.lezcano@linaro.org>

From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>

Replace the driver-specific thread-safe shared register API
by the recently introduced atomic_io_clear_set().

Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/time-armada-370-xp.c |   12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c
index ee8691b..0451e62 100644
--- a/drivers/clocksource/time-armada-370-xp.c
+++ b/drivers/clocksource/time-armada-370-xp.c
@@ -85,12 +85,6 @@ static u32 ticks_per_jiffy;
 
 static struct clock_event_device __percpu *armada_370_xp_evt;
 
-static void timer_ctrl_clrset(u32 clr, u32 set)
-{
-	writel((readl(timer_base + TIMER_CTRL_OFF) & ~clr) | set,
-		timer_base + TIMER_CTRL_OFF);
-}
-
 static void local_timer_ctrl_clrset(u32 clr, u32 set)
 {
 	writel((readl(local_base + TIMER_CTRL_OFF) & ~clr) | set,
@@ -245,7 +239,7 @@ static void __init armada_370_xp_timer_common_init(struct device_node *np)
 		clr = TIMER0_25MHZ;
 		enable_mask = TIMER0_EN | TIMER0_DIV(TIMER_DIVIDER_SHIFT);
 	}
-	timer_ctrl_clrset(clr, set);
+	atomic_io_modify(timer_base + TIMER_CTRL_OFF, clr | set, set);
 	local_timer_ctrl_clrset(clr, set);
 
 	/*
@@ -263,7 +257,9 @@ static void __init armada_370_xp_timer_common_init(struct device_node *np)
 	writel(0xffffffff, timer_base + TIMER0_VAL_OFF);
 	writel(0xffffffff, timer_base + TIMER0_RELOAD_OFF);
 
-	timer_ctrl_clrset(0, TIMER0_RELOAD_EN | enable_mask);
+	atomic_io_modify(timer_base + TIMER_CTRL_OFF,
+		TIMER0_RELOAD_EN | enable_mask,
+		TIMER0_RELOAD_EN | enable_mask);
 
 	/*
 	 * Set scale and timer for sched_clock.
-- 
1.7.9.5


  parent reply	other threads:[~2014-03-11 22:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11 22:35 [GIT PR] clockevents : new material for 3.15 Daniel Lezcano
2014-03-11 22:40 ` [PATCH 01/17] clocksource: arch_timer: Set dynamic irq affinity on mmio clockevent Daniel Lezcano
2014-03-11 22:40   ` [PATCH 02/17] ARM: u300: move timer driver to clocksource Daniel Lezcano
2014-03-11 22:40   ` [PATCH 03/17] clocksource: sunxi: Add new compatibles Daniel Lezcano
2014-03-11 22:40   ` [PATCH 04/17] ARM: sunxi: dt: Convert to the new clocksource compatible Daniel Lezcano
2014-03-11 22:40   ` [PATCH 05/17] clocksource: keystone: add bindings for keystone timer Daniel Lezcano
2014-03-11 22:40   ` [PATCH 06/17] clocksource: timer-keystone: introduce clocksource driver for Keystone Daniel Lezcano
2014-03-11 22:40   ` [PATCH 07/17] clocksource: timer-keystone: Delete unnecessary variable Daniel Lezcano
2014-03-11 22:40   ` [PATCH 08/17] clocksource: orion: Use atomic access for shared registers Daniel Lezcano
2014-03-11 22:40   ` Daniel Lezcano [this message]
2014-03-11 22:40   ` [PATCH 10/17] ARM: shmobile: Remove CMT, TMU and STI Kconfig entries Daniel Lezcano
2014-03-11 22:40   ` [PATCH 11/17] sh: Remove Kconfig entries for TMU, CMT and MTU2 Daniel Lezcano
2014-03-11 22:40   ` [PATCH 12/17] clocksource: Add Kconfig entries for CMT, MTU2, TMU and STI Daniel Lezcano
2014-03-11 22:40   ` [PATCH 13/17] clocksource/cadence_ttc: Call clockevents_update_freq() with IRQs enabled Daniel Lezcano
2014-03-11 22:40   ` [PATCH 14/17] clocksource/cadence_ttc: Overhaul clocksource frequency adjustment Daniel Lezcano
2014-03-11 22:40   ` [PATCH 15/17] arm: zynq: Don't use arm_global_timer with cpufreq Daniel Lezcano
2014-03-11 22:40   ` [PATCH 16/17] arm: zynq: Add support for cpufreq Daniel Lezcano
2014-03-11 22:40   ` [PATCH 17/17] clocksource: exynos_mct: silence a static checker warning Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394577653-8615-9-git-send-email-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=dan.carpenter@oracle.com \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=ivan.khoronzhuk@ti.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mingo@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=soren.brinkmann@xilinx.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome