From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH 1/6] cputime: Fix nsecs_to_cputime() return type cast
Date: Wed, 12 Mar 2014 03:09:57 +0100 [thread overview]
Message-ID: <1394590202-772-2-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1394590202-772-1-git-send-email-fweisbec@gmail.com>
Even though nsec based cputime_t maps to u64, nsecs_to_cputime() must
return a cputime_t value. We want to enforce this kind of cast in order
to track down buggy manipulations of cputime_t such as direct access
of its values under wrong assumptions on its backend type (nsecs,
jiffies, etc...) by core code.
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Rik van Riel <riel@redhat.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
include/asm-generic/cputime_nsecs.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/asm-generic/cputime_nsecs.h b/include/asm-generic/cputime_nsecs.h
index 2c9e62c..768294f 100644
--- a/include/asm-generic/cputime_nsecs.h
+++ b/include/asm-generic/cputime_nsecs.h
@@ -44,7 +44,8 @@ typedef u64 __nocast cputime64_t;
/*
* Convert cputime <-> nanoseconds
*/
-#define nsecs_to_cputime(__nsecs) ((__force u64)(__nsecs))
+#define nsecs_to_cputime(__nsecs) \
+ (__force cputime_t)(__nsecs)
/*
--
1.8.3.1
next prev parent reply other threads:[~2014-03-12 2:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 2:09 [GIT PULL] timers updates for 3.15 Frederic Weisbecker
2014-03-12 2:09 ` Frederic Weisbecker [this message]
2014-03-12 2:09 ` [PATCH 2/6] cputime: Default implementation of nsecs -> cputime conversion Frederic Weisbecker
2014-03-12 2:09 ` [PATCH 3/6] cputime: Bring cputime -> nsecs conversion Frederic Weisbecker
2014-03-12 2:10 ` [PATCH 4/6] cputime: Fix jiffies based cputime assumption on steal accounting Frederic Weisbecker
2014-03-12 2:10 ` [PATCH 5/6] sched: Remove needless round trip nsecs <-> tick conversion of steal time Frederic Weisbecker
2014-03-12 2:10 ` [PATCH 6/6] arch: Remove stub cputime.h headers Frederic Weisbecker
2014-03-12 9:44 ` Peter Zijlstra
2014-03-12 15:23 ` Frederic Weisbecker
2014-03-12 15:26 ` Peter Zijlstra
2014-03-12 15:47 ` Frederic Weisbecker
2014-03-12 16:23 ` [PATCH v2] " Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2014-03-06 17:56 [PATCH 0/6] cputime: Fixes and cleanups on steal time accounting Frederic Weisbecker
2014-03-06 17:56 ` [PATCH 1/6] cputime: Fix nsecs_to_cputime() return type cast Frederic Weisbecker
2014-03-06 18:57 ` Rik van Riel
2014-03-12 2:14 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394590202-772-2-git-send-email-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mtosatti@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome