mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Ruchi Kandoi <kandoiruchi@google.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	rjw@rjwysocki.net, ghackmann@google.com, john.stultz@linaro.org,
	toddpoynor@google.com
Subject: Re: [PATCH v3] power: add an API to log wakeup reasons
Date: Wed, 12 Mar 2014 12:50:50 -0700	[thread overview]
Message-ID: <1394653850.3915.26.camel@joe-AO722> (raw)
In-Reply-To: <1394653598-17143-1-git-send-email-kandoiruchi@google.com>

On Wed, 2014-03-12 at 12:46 -0700, Ruchi Kandoi wrote:
> For power management diagnostic purposes, it is often useful to know
> what interrupts are frequently waking the system from low power
> suspend mode, especially on battery-powered consumer electronics
> devices that are expected to spend much of their time in low-power
> suspend while not in active use.  For example, reduced battery life on
> a mobile phone may be caused in part by frequent wakeups by broadcast
> traffic on a busy wireless LAN even while the screen is off and the
> phone not in active use.

trivial note:

> diff --git a/kernel/power/wakeup_reason.c b/kernel/power/wakeup_reason.c
[]
> +#define pr_fmt(fmt) "wakeup_reason:" fmt

It's almost universal in the kernel to have a space after the :
in the prefix

#define pr_fmt(fmt) "wakeup_reason: " fmt



  reply	other threads:[~2014-03-12 19:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-12 19:46 Ruchi Kandoi
2014-03-12 19:50 ` Joe Perches [this message]
2014-03-13 22:18 ` Rafael J. Wysocki
2014-03-14  0:43   ` Ruchi Kandoi
2014-03-14  1:06     ` Rafael J. Wysocki
2014-03-14  2:15       ` Ruchi Kandoi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394653850.3915.26.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=ghackmann@google.com \
    --cc=john.stultz@linaro.org \
    --cc=kandoiruchi@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=toddpoynor@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®