mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hayes Wang <hayeswang@realtek.com>
To: <netdev@vger.kernel.org>
Cc: <nic_swsd@realtek.com>, <linux-kernel@vger.kernel.org>,
	<linux-usb@vger.kernel.org>
Subject: [PATCH net-next] r8152: replace strncpy with strlcpy
Date: Tue, 26 Aug 2014 10:08:23 +0800	[thread overview]
Message-ID: <1394712342-15778-22-Taiwan-albertk@realtek.com> (raw)
In-Reply-To: <1394712342-15778-16-Taiwan-albertk@realtek.com>

Replace the strncpy with strlcpy, and use sizeof to determine the
length.

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
---
 drivers/net/usb/r8152.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 2470d9c..33dcc97 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -3151,8 +3151,8 @@ static void rtl8152_get_drvinfo(struct net_device *netdev,
 {
 	struct r8152 *tp = netdev_priv(netdev);
 
-	strncpy(info->driver, MODULENAME, ETHTOOL_BUSINFO_LEN);
-	strncpy(info->version, DRIVER_VERSION, ETHTOOL_BUSINFO_LEN);
+	strlcpy(info->driver, MODULENAME, sizeof(info->driver));
+	strlcpy(info->version, DRIVER_VERSION, sizeof(info->version));
 	usb_make_path(tp->udev, info->bus_info, sizeof(info->bus_info));
 }
 
-- 
1.9.3


  parent reply	other threads:[~2014-08-26  2:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-20  8:58 [PATCH net-next 0/4] r8152: firmware support Hayes Wang
2014-08-20  8:58 ` [PATCH net-next 1/4] r8152: check code with checkpatch.pl Hayes Wang
2014-08-20  8:58 ` [PATCH net-next 2/4] r8152: replace strncpy with strlcpy Hayes Wang
2014-08-20  8:58 ` [PATCH net-next 3/4] r8152: remove clear_bp function Hayes Wang
2014-08-20 12:00   ` Sergei Shtylyov
     [not found]   ` <201408210131.s7L1VuAJ031162@rtits1.realtek.com>
2014-08-21  2:12     ` Hayes Wang
2014-08-21 17:29       ` Sergei Shtylyov
2014-08-22  2:38         ` Hayes Wang
2014-08-20  8:58 ` [PATCH net-next 4/4] r8152: support firmware files Hayes Wang
2014-08-20 12:01   ` Daniele Forsi
2014-08-20 12:35     ` Hayes Wang
2014-08-20 13:32       ` Daniele Forsi
2014-08-24 21:20   ` Francois Romieu
2014-08-25  3:23     ` Hayes Wang
2014-08-23  2:41 ` [PATCH net-next 0/4] r8152: firmware support David Miller
2014-08-25  3:43   ` Hayes Wang
2014-08-25  4:26     ` David Miller
2014-08-25  6:43       ` Hayes Wang
2014-08-25  7:00         ` David Miller
2014-08-25  7:53 ` [PATCH net-next] r8152: check code with checkpatch.pl Hayes Wang
2014-08-25 19:58   ` David Miller
2014-08-26  2:08 ` Hayes Wang [this message]
2014-08-27 23:18   ` [PATCH net-next] r8152: replace strncpy with strlcpy David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394712342-15778-22-Taiwan-albertk@realtek.com \
    --to=hayeswang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®