From: Joe Perches <joe@perches.com>
To: Sam Bradshaw <sbradshaw@micron.com>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, asamymuthupa@micron.com
Subject: Re: [PATCH] mtip32xx: switch to vmalloc() to mitigate high order allocation failures
Date: Fri, 14 Mar 2014 00:48:03 -0700 [thread overview]
Message-ID: <1394783283.2970.2.camel@joe-AO722> (raw)
In-Reply-To: <532237F4.3010309@micron.com>
On Thu, 2014-03-13 at 15:57 -0700, Sam Bradshaw wrote:
> The mtip_port kmalloc() allocation is relatively high order, in
> particular since the recent doubling of the size of the scatterlist
> container. The allocation has been shown to fail during SRSI under
> fragmented or low memory conditions. Switching to vmalloc() mitigates
> the problem. Converted both mtip_port and driver_data allocations for
> consistency.
It'd probably be better to use kmalloc and then
only if it fails use vmalloc.
See examples like net/sched/sch_hhf.c
prev parent reply other threads:[~2014-03-14 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 22:57 Sam Bradshaw
2014-03-14 7:48 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394783283.2970.2.camel@joe-AO722 \
--to=joe@perches.com \
--cc=asamymuthupa@micron.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=sbradshaw@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®