From: Tomas Winkler <tomas.winkler@intel.com>
To: gregkh@linuxfoundation.org
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
Tomas Winkler <tomas.winkler@intel.com>
Subject: [char-misc-next 4/5] mei: amthif: fix checkpatch error
Date: Sun, 16 Mar 2014 14:35:57 +0200 [thread overview]
Message-ID: <1394973358-21690-5-git-send-email-tomas.winkler@intel.com> (raw)
In-Reply-To: <1394973358-21690-1-git-send-email-tomas.winkler@intel.com>
ERROR: else should follow close brace '}'
+ }
+ else {
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
drivers/misc/mei/amthif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/misc/mei/amthif.c b/drivers/misc/mei/amthif.c
index 2052609..b8deb34 100644
--- a/drivers/misc/mei/amthif.c
+++ b/drivers/misc/mei/amthif.c
@@ -247,8 +247,7 @@ int mei_amthif_read(struct mei_device *dev, struct file *file,
if (copy_to_user(ubuf, cb->response_buffer.data + *offset, length)) {
dev_dbg(&dev->pdev->dev, "failed to copy data to userland\n");
rets = -EFAULT;
- }
- else {
+ } else {
rets = length;
if ((*offset + length) < cb->buf_idx) {
*offset += length;
--
1.8.5.3
next prev parent reply other threads:[~2014-03-16 12:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-16 12:35 [char-misc-next 0/5] mei: cleanup some checkpatch issues Tomas Winkler
2014-03-16 12:35 ` [char-misc-next 1/5] mei: fix Unnecessary space after function pointer name Tomas Winkler
2014-03-16 12:35 ` [char-misc-next 2/5] mei: use cl_dbg where appropriate Tomas Winkler
2014-03-16 16:36 ` Joe Perches
2014-03-16 22:19 ` Winkler, Tomas
2014-03-16 23:09 ` Joe Perches
2014-03-16 12:35 ` [char-misc-next 3/5] mei: client.h fix checkpetch errors Tomas Winkler
2014-03-16 12:35 ` Tomas Winkler [this message]
2014-03-16 12:35 ` [char-misc-next 5/5] mei: don't use deprecated DEFINE_PCI_DEVICE_TABLE macro Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394973358-21690-5-git-send-email-tomas.winkler@intel.com \
--to=tomas.winkler@intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®