mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Daniel Ngu <daniel.dy.ngu@gmail.com>
Cc: Jonathan Kim <jonathankim@gctsemi.com>,
	Dean ahn <deanahn@gctsemi.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: gdm724x: gdm_lte.h: fixed coding style
Date: Sun, 16 Mar 2014 12:21:34 -0700	[thread overview]
Message-ID: <1394997694.5689.58.camel@joe-AO722> (raw)
In-Reply-To: <20140316191817.GD3478@quad>

On Mon, 2014-03-17 at 08:18 +1300, Daniel Ngu wrote:
> Missing space after return type

Not really.

> diff --git a/drivers/staging/gdm724x/gdm_lte.h b/drivers/staging/gdm724x/gdm_lte.h
[]
> @@ -56,7 +56,7 @@ struct phy_dev {
>  			int (*cb)(void *cb_data, void *data, int len,
>  				  int context),
>  			void *cb_data, int context);
> -	struct gdm_endian *(*get_endian)(void *priv_dev);
> +	struct gdm_endian * (*get_endian)(void *priv_dev);

That one was a defect in checkpatch that was
corrected in -next by:

commit 93ca9441419b0bfbf96243e01f39b5a80565215e
Author: Joe Perches <joe@perches.com>
Date:   Thu Mar 6 11:02:08 2014 +1100

    checkpatch: don't warn on some function pointer return styles
    
    Checks for some function pointer return styles are too strict.  Fix them.
    
    Multiple spaces after function pointer return types are allowed.
        int  (*foo)(int bar)
    
    Spaces after function pointer returns of pointer types are not required.
        int *(*foo)(int bar)



      reply	other threads:[~2014-03-16 19:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-16 19:18 Daniel Ngu
2014-03-16 19:21 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394997694.5689.58.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=daniel.dy.ngu@gmail.com \
    --cc=deanahn@gctsemi.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=jonathankim@gctsemi.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®