From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86F1F286402 for ; Tue, 19 Aug 2025 09:04:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755594260; cv=none; b=m36W8g8uJX3ksQ78RfILdlN4pCEeB2mZQXMPPe4Kuj7QUSUDp+0Qyh9JO02FO2Rll0xOpaLkoFzVYjrf8uJkZMH4L9WkQRW5iHQ0Mxg9OWEH45mWIvlWgWPn5dWSPaQVtwpy1Mx0mQaFCWPphaib7hkERu3K/ZYX2OGPVQ1Izzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755594260; c=relaxed/simple; bh=Ur/EDwulXmk+KxS1Iyo/HiGIsV1LuoVRseDCDX7NNHk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=H/nfKaY6OJ1iCkfW+PY/zxGYFSbH6bUxtuqxDUzev8ySw8hGE95LPM0xkXn3ARU4UCUZ9CnZy9I70/RFtsNaBYhxKNtHC8d6tLnyMMUA8yf0x8mrCRWZogixBKkSptuz/vW/jTUEYpXbTDZqmY02ljnnnUGjGYgyoIIXMOB0d44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nb05A76Y; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nb05A76Y" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57J90XWC007201 for ; Tue, 19 Aug 2025 09:04:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PtQwBBE7A/L6DYrB3suka029FN2KX9K7yxrcnIgCQII=; b=nb05A76YpPiOGSz2 vwKgyfBmE6HTLMxdi6KMSAwl+lCIrsM15BUf4wC5FcFazt++cmigwggE66ZVHZ+Z LII/VhS37canuQuPj57BEoCVcQtDCQRHJZa1bDvjE7RmxNwQuI0qOdLDNEouVx1W RXipSQsgCZ2tXrvtKmTPYVnzEQY10R31absN9NHWNQ4LNLFpHAHGlrwczdPAbeZK 8CvgKPFlbbnMT31my/tqNor12JVqpfefFg4bdNMJ7bIVA2gjNFoaNn6ovC/0KrYy e3hZjWpl7xsh7UcxJcedHUcNRbJkRpLhqe2wYrcCxtTZakAiMefhOTSv3tC8E9Lk zG1gJw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48jj747x70-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 19 Aug 2025 09:04:17 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2430c5d4d73so69192285ad.1 for ; Tue, 19 Aug 2025 02:04:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755594257; x=1756199057; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PtQwBBE7A/L6DYrB3suka029FN2KX9K7yxrcnIgCQII=; b=Q+iCwAtNFVG1vcITmiyCnPVs3kVHqneBJLPC8Drvl7geoD3LqFQqtjHfGRgMfmqXKG n1jLp5qEd8Lquch3LyAjfubzu43Jr0AxZLRcj4IDiC4UFnwaNIlR22gQ3kyXtLXKX5uU VlcJQq4Dgh70JS4u7Cyrp5a1tdxK7A2Va+EE6HQ33VuLasbo+HRkFJaF6RSsvR3509WE gAQ7Y8vpbpvsG/NXVkSah1jAMGsQLxK19PAfrJSygOf0PttXjzUn4yLwRTwq8amL+YEB t/e86jCtO3FOVnVqXrwzj4xwGw2dh06o60mA2XDzBs9Pv/JvkzmOfMzIbxdVGhvrtysz s6vg== X-Forwarded-Encrypted: i=1; AJvYcCXgcJnJhjDWdcZLIW65cYN5PGX9dgUnp6WVJvJudG7EA4QhLtoPqBMUG+TU39JHJXE+NArpMe3FLD7NuCs=@vger.kernel.org X-Gm-Message-State: AOJu0YzcDan38N4z8HGCuabV63lDFVl2W94OUZQVED9F2Keb81a/SyGf dkB+y6HbqAQ/Lg+AU6TeHvS659LuczDz9cl/vvlYp52KIBSQzpp+cKf7IVROy8neP54FBEpaZuz 8AnDC+HPx2etRbKHdmrtxst1c1z6gpe3/gtMQd+RRtIli8W6B977cHErwtLv8B4vbktc= X-Gm-Gg: ASbGncs5/cMII0zLzdssNDRXebYNeSf6kyJhrE/yHQFnUtsaklXX/yJeI+X6F+kzN7q 12iK5zpPBFXyUgTKT4iTZXoVpPXg8glD5c5DJq6aRhxrlDi6dh4D1su8n3fBapzyGkQSoMydG7i CyCeUXuaFzWHRBot/hGfvAyYPnOzNuSdr4l1PnJIZ9DyallcOrdigiwA8TJllwKDUyvQ99kvzyi IeQt17E+NBOYc7icsA0eIhwEWHaI+Q9fBXHpD53LhddTEl17Y3cp0pHyX37NYsys80YMRrveb53 YyvPspbuZZ+NUf7MjG/VnfHoDuKcVfeb+z0JErO+1YFyuBzJVzQ+RJJTVp1zbbNs8oq4tGxCytI x7hnUn5et63fIJQKdFDYQVP+cga9DTSPM X-Received: by 2002:a17:903:1205:b0:231:d0da:5e1f with SMTP id d9443c01a7336-245e0f2775amr16133965ad.21.1755594256739; Tue, 19 Aug 2025 02:04:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFkh7QwrfpTpI4CY81hIJagXgTCB6D+xkbxXMTtgq4VmPlFbLxOxb5dFrnqC4gKaobuk82+qA== X-Received: by 2002:a17:903:1205:b0:231:d0da:5e1f with SMTP id d9443c01a7336-245e0f2775amr16133355ad.21.1755594256080; Tue, 19 Aug 2025 02:04:16 -0700 (PDT) Received: from [10.133.33.88] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2446d50f8d0sm102888145ad.100.2025.08.19.02.04.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Aug 2025 02:04:15 -0700 (PDT) Message-ID: <1394aa43-3edc-4ed5-9662-43d98bf8d85f@oss.qualcomm.com> Date: Tue, 19 Aug 2025 17:04:07 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/6] arm64: dts: qcom: qcs615: add ethernet node To: Krzysztof Kozlowski , Vinod Koul , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran Cc: netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable+noautosel@kernel.org, Yijie Yang , Konrad Dybcio References: <20250819-qcs615_eth-v4-0-5050ed3402cb@oss.qualcomm.com> <20250819-qcs615_eth-v4-3-5050ed3402cb@oss.qualcomm.com> <157c048d-0efd-458c-8a3f-dfc30d07edf8@oss.qualcomm.com> <0b53dc0b-a96f-49e1-a81e-3748fa908144@kernel.org> Content-Language: en-US From: Yijie Yang In-Reply-To: <0b53dc0b-a96f-49e1-a81e-3748fa908144@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 7QR3pwhzrmCJl9LLOFZFBxsuagzsdhp9 X-Proofpoint-ORIG-GUID: 7QR3pwhzrmCJl9LLOFZFBxsuagzsdhp9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODE2MDAzMyBTYWx0ZWRfX43uNw4/mbJcz uAzjQzyzPmAsSu+7iSQ2ZgKat+jbokhKomm2bQzSC1I9gFd7U8ye4bPe5lSiIVB4C1eEgOxUQ6w i2MPE546xAHjTz278U16v7wTgosNdIjvm3NN/qtQRFZv9XKYE7LvcIMn5E1wCNqbyk6eGxkKU7G M2OeB2FrJhBhKlIwrvsON5ZuBN1piv4JJdLbaYBcLwDtiI56MqFeHC0rBRQBtz5EgEI+hQr+MsM CzEGbhq3b2ldyk9UAWDb0toKrRi5XI7jLa6WLh+/HYo+p8HfBs3DsbRtFXnfwEivcDJVVplNZSg F1fJB7O2p/4oQNXhF8mgyorBxgwA4Dm3ZtV4CyE8+QfCVXPwd22fHYFuf2IeEOvs7BILmqw1x32 2PkfdwFt X-Authority-Analysis: v=2.4 cv=MJtgmNZl c=1 sm=1 tr=0 ts=68a43e11 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=WpKivvdH6quKUe0GCQ0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-19_01,2025-08-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508160033 On 2025-08-19 15:15, Krzysztof Kozlowski wrote: > On 19/08/2025 08:51, Yijie Yang wrote: >> >> >> On 2025-08-19 14:44, Krzysztof Kozlowski wrote: >>> On 19/08/2025 08:35, YijieYang wrote: >>>> From: Yijie Yang >>>> >>>> Add an ethernet controller node for QCS615 SoC to enable ethernet >>>> functionality. >>>> >>>> Reviewed-by: Konrad Dybcio >>>> Signed-off-by: Yijie Yang >>>> --- >>> >>> >>> Why do you mix up DTS and net-next patches? This only makes difficult to >>> apply it, for no benefits. >> >> The DTS changes and driver code modifications work together to achieve a >> single purpose, so I included them in one patch series. Should I >> consider splitting them into two separate series? > Of course yes. You are just making difficult to apply this. Patches are > completely independent and even your internal guideline asks to NOT > combine independent patches. The challenge with splitting this series lies in the fact that it attempts to reverse the incorrect semantics of phy-mode in both the driver code and the device tree. Selecting only part of the series would break Ethernet functionality on both boards. As you can see, I’ve CC’d noautosel to prevent this issue. Given the circumstances, I’m wondering if it would be acceptable to leave the series as-is? > > Best regards, > Krzysztof -- Best Regards, Yijie