From: Joe Perches <joe@perches.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
akpm <akpm@linux-foundation.org>, anton <anton@tuxera.com>
Subject: Re: [PATCH V2] NTFS: Logging clean-up
Date: Sun, 16 Mar 2014 14:27:16 -0700 [thread overview]
Message-ID: <1395005236.31843.1.camel@joe-AO722> (raw)
In-Reply-To: <20140316215238.ba9af67aa774882cc96f4161@skynet.be>
On Sun, 2014-03-16 at 21:52 +0100, Fabian Frederick wrote:
> -Convert spinlock/stat array to va_format (inspired by Joe Perches help
> on previous logging patches).
> -Convert printk(KERN_ERR to pr_warn in __ntfs_warning.
> -Convert printk(KERN_ERR to pr_err in __ntfs_error.
> -Convert printk(KERN_DEBUG to pr_debug in __ntfs_debug.
[]
> diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c
[]
> @@ -3093,7 +3094,7 @@ static int __init init_ntfs_fs(void)
> int err = 0;
>
> /* This may be ugly but it results in pretty output so who cares. (-8 */
> - printk(KERN_INFO "NTFS driver " NTFS_VERSION " [Flags: R/"
> + pr_info(NTFS_VERSION " [Flags: R/"
Be nice to have this say pr_info("driver " NTFS_VERSION " etc...
Other than that, seems like a nice cleanup, thanks.
prev parent reply other threads:[~2014-03-16 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-16 20:52 Fabian Frederick
2014-03-16 21:27 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395005236.31843.1.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=anton@tuxera.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®