From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: "Thierry Reding" <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
"Lothar Waßmann" <LW@KARO-electronics.de>
Subject: [PATCHv3 3/3] pwm: imx: support output polarity inversion
Date: Wed, 19 Mar 2014 14:22:55 +0100 [thread overview]
Message-ID: <1395235375-12925-4-git-send-email-LW@KARO-electronics.de> (raw)
In-Reply-To: <1395235375-12925-1-git-send-email-LW@KARO-electronics.de>
The i.MX pwm unit on i.MX27 and newer SoCs provides a configurable
output polarity. This patch adds support to utilize this feature where
available.
Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
drivers/pwm/pwm-imx.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index 52aac5e..a43410a 100644
--- a/drivers/pwm/pwm-imx.c
+++ b/drivers/pwm/pwm-imx.c
@@ -138,6 +138,8 @@ static int imx_pwm_config_v2(struct pwm_chip *chip,
if (test_bit(PWMF_ENABLED, &pwm->flags))
cr |= MX3_PWMCR_EN;
+ if (pwm->polarity == PWM_POLARITY_INVERSED)
+ cr |= MX3_PWMCR_POUTC;
writel(cr, imx->mmio_base + MX3_PWMCR);
@@ -156,6 +158,11 @@ static void imx_pwm_set_enable_v2(struct pwm_chip *chip, bool enable)
else
val &= ~MX3_PWMCR_EN;
+ if (chip->pwms[0].polarity == PWM_POLARITY_INVERSED)
+ val |= MX3_PWMCR_POUTC;
+ else
+ val &= ~MX3_PWMCR_POUTC;
+
writel(val, imx->mmio_base + MX3_PWMCR);
}
@@ -199,6 +206,17 @@ static void imx_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
clk_disable_unprepare(imx->clk_per);
}
+static int imx_pwm_set_polarity(struct pwm_chip *chip, struct pwm_device *pwm,
+ enum pwm_polarity polarity)
+{
+ struct imx_chip *imx = to_imx_chip(chip);
+
+ dev_dbg(imx->chip.dev, "%s: polarity set to %s\n", __func__,
+ polarity == PWM_POLARITY_INVERSED ? "inverted" : "normal");
+
+ return 0;
+}
+
static struct pwm_ops imx_pwm_ops = {
.enable = imx_pwm_enable,
.disable = imx_pwm_disable,
@@ -210,6 +228,7 @@ struct imx_pwm_data {
int (*config)(struct pwm_chip *chip,
struct pwm_device *pwm, int duty_ns, int period_ns);
void (*set_enable)(struct pwm_chip *chip, bool enable);
+ unsigned output_polarity:1;
};
static struct imx_pwm_data imx_pwm_data_v1 = {
@@ -220,6 +239,7 @@ static struct imx_pwm_data imx_pwm_data_v1 = {
static struct imx_pwm_data imx_pwm_data_v2 = {
.config = imx_pwm_config_v2,
.set_enable = imx_pwm_set_enable_v2,
+ .output_polarity = 1,
};
static const struct of_device_id imx_pwm_dt_ids[] = {
@@ -272,6 +292,11 @@ static int imx_pwm_probe(struct platform_device *pdev)
return PTR_ERR(imx->mmio_base);
data = of_id->data;
+ if (data->output_polarity) {
+ dev_dbg(&pdev->dev, "PWM supports output inversion\n");
+ imx_pwm_ops.set_polarity = imx_pwm_set_polarity;
+ }
+
imx->config = data->config;
imx->set_enable = data->set_enable;
--
1.7.10.4
next prev parent reply other threads:[~2014-03-19 13:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 13:22 Lothar Waßmann
2014-03-19 13:22 ` [PATCHv3 1/3] pwm: make the PWM_POLARITY flag in DTB optional Lothar Waßmann
2014-03-19 13:22 ` [PATCHv3 2/3] pwm: imx: indentation cleanup Lothar Waßmann
2014-03-19 13:22 ` Lothar Waßmann [this message]
2014-03-28 8:48 ` [PATCHv3 0/3] pwm: imx: support output polarity inversion Lothar Waßmann
2014-03-28 8:48 ` [PATCHv3 1/3] pwm: make the PWM_POLARITY flag in DTB optional Lothar Waßmann
2014-04-02 5:53 ` Sascha Hauer
2014-04-07 11:36 ` Thierry Reding
2014-04-08 5:02 ` Lothar Waßmann
2014-04-08 20:43 ` Tim Kryger
2014-04-09 6:12 ` Sascha Hauer
2014-04-09 7:22 ` Thierry Reding
2014-04-10 5:55 ` Sascha Hauer
[not found] ` <CAAYSxhpL_0FJvuvGODMTZDm7DtK3eBTVYdhf1Ot7PW94gSM8iw@mail.gmail.com>
2014-04-09 6:04 ` Lothar Waßmann
2014-04-09 7:16 ` Thierry Reding
2014-03-28 8:48 ` [PATCHv3 2/3] pwm: imx: indentation cleanup Lothar Waßmann
2014-03-28 8:49 ` [PATCHv3 3/3] pwm: imx: support output polarity inversion Lothar Waßmann
2014-04-02 5:45 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395235375-12925-4-git-send-email-LW@KARO-electronics.de \
--to=lw@karo-electronics.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®