From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759116AbaCTPQ1 (ORCPT ); Thu, 20 Mar 2014 11:16:27 -0400 Received: from mail1.windriver.com ([147.11.146.13]:57645 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757067AbaCTPQZ (ORCPT ); Thu, 20 Mar 2014 11:16:25 -0400 From: Paul Gortmaker To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen CC: , , Jim Davis , Fengguang Wu , Paul Gortmaker Subject: [PATCH] drivers/video: fix mb862xx_i2c depends issue build failure Date: Thu, 20 Mar 2014 11:16:00 -0400 Message-ID: <1395328560-48497-1-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 1.9.0 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Any randconfig that sets I2C=m and FB_MB862XX_I2C=y will encounter a final link failure that looks like this: drivers/built-in.o: In function `mb862xx_i2c_init': drivers/video/mb862xx/mb862xx-i2c.c:165: undefined reference to `i2c_add_adapter' drivers/built-in.o: In function `mb862xx_i2c_exit': drivers/video/mb862xx/mb862xx-i2c.c:176: undefined reference to `i2c_del_adapter' Since FB_MB862XX_I2C is a bool and not tristate, simply don't offer it at all if core I2C support is not built in. Reported-by: Jim Davis Reported-by: Fengguang Wu Signed-off-by: Paul Gortmaker diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index dade5b7699bc..aefd1b9a3cbd 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -2338,7 +2338,7 @@ endchoice config FB_MB862XX_I2C bool "Support I2C bus on MB862XX GDC" - depends on FB_MB862XX && I2C + depends on FB_MB862XX && I2C=y default y help Selecting this option adds Coral-P(A)/Lime GDC I2C bus adapter -- 1.9.0