From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759667AbaCTTzh (ORCPT ); Thu, 20 Mar 2014 15:55:37 -0400 Received: from www.linutronix.de ([62.245.132.108]:45255 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755381AbaCTTzc (ORCPT ); Thu, 20 Mar 2014 15:55:32 -0400 From: Sebastian Andrzej Siewior To: Alan Tull Cc: Linus Walleij , Alexandre Courbot , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Dinh Nguyen , Sebastian Andrzej Siewior Subject: [PATCH 1/3] gpio: dwapb: drop irq_setup_generic_chip() Date: Thu, 20 Mar 2014 20:55:22 +0100 Message-Id: <1395345324-18299-2-git-send-email-bigeasy@linutronix.de> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1395345324-18299-1-git-send-email-bigeasy@linutronix.de> References: <1395345324-18299-1-git-send-email-bigeasy@linutronix.de> X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This looks kinda wrong I didn't manage to fully test it. The driver calls irq_alloc_domain_generic_chips() which creates a gc and adds it to gc_list. The driver later then calls irq_setup_generic_chip() which also initializes the gc and adds it to the gc_list() and this corrupts the list. I can't find a single chip in tree which uses both functions so I think that irq_setup_generic_chip() can be dropped. Signed-off-by: Sebastian Andrzej Siewior --- drivers/gpio/gpio-dwapb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c index ed5711f..4d25a06b 100644 --- a/drivers/gpio/gpio-dwapb.c +++ b/drivers/gpio/gpio-dwapb.c @@ -260,9 +260,6 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio, ct->regs.ack = GPIO_PORTA_EOI; ct->regs.mask = GPIO_INTMASK; - irq_setup_generic_chip(irq_gc, IRQ_MSK(port->bgc.gc.ngpio), - IRQ_GC_INIT_NESTED_LOCK, IRQ_NOREQUEST, 0); - irq_set_chained_handler(irq, dwapb_irq_handler); irq_set_handler_data(irq, gpio); -- 1.9.1