From: David Laight <David.Laight@ACULAB.COM>
To: "'Stefano Stabellini'" <sstabellini@kernel.org>,
"jgross@suse.com" <jgross@suse.com>,
"boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] pvcalls-front: 64-bit align flags
Date: Wed, 28 Feb 2018 09:06:17 +0000 [thread overview]
Message-ID: <139554adced44c5ea5aa4fab4f0ca8a0@AcuMS.aculab.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1802271150020.4239@sstabellini-ThinkPad-X260>
From: Stefano Stabellini
> Sent: 27 February 2018 19:55
>
> We are using test_and_* operations on the status and flag fields of
> struct sock_mapping. However, these functions require the operand to be
> 64-bit aligned on arm64. Currently, only status is 64-bit aligned.
That sounds like a big accident just waiting to happen...
If the operand is required to be 64bit aligned why isn't it a type
that requires 64bit alignment?
> Make flags 64-bit aligned by introducing an explicit padding field.
At some point such padding will always go wrong...
David
prev parent reply other threads:[~2018-02-28 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 19:54 Stefano Stabellini
2018-02-27 21:19 ` Boris Ostrovsky
2018-02-27 21:32 ` Stefano Stabellini
2018-02-27 21:45 ` Boris Ostrovsky
2018-02-27 21:50 ` Stefano Stabellini
2018-02-28 9:06 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=139554adced44c5ea5aa4fab4f0ca8a0@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®