mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Liu Hua <sdu.liu@huawei.com>
To: <paul.gortmaker@windriver.com>
Cc: <mingo@kernel.org>, <wangnan0@huawei.com>,
	<linux-kernel@vger.kernel.org>, <peifeiyue@huawei.com>,
	<lizefan@huawei.com>, Liu Hua <sdu.liu@huawei.com>,
	<stable@vger.kernel.org>
Subject: [PATCH v2] hung_task : check the value of "sysctl_hung_task_timeout_sec"
Date: Sun, 23 Mar 2014 15:54:04 +0800	[thread overview]
Message-ID: <1395561244-69173-1-git-send-email-sdu.liu@huawei.com> (raw)

As sysctl_hung_task_timeout_sec is unsigned long, when this value is
larger then LONG_MAX/HZ, the function schedule_timeout_interruptible in
watchdog will return immediately without sleep and with print :

[  205.452934] schedule_timeout: wrong timeout value ffffffffffffff83

and then the funtion watchdog will call schedule_timeout_interruptible again
and again. The screen will be filled with
	"schedule_timeout: wrong timeout value ffffffffffffff83"

This patch does some check and correction in timeout_jiffies, to let the
function schedule_timeout_interruptible allways get the valid parameter.

Cc: <stable@vger.kernel.org>
Signed-off-by: Liu Hua <sdu.liu@huawei.com>
---
 kernel/hung_task.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/kernel/hung_task.c b/kernel/hung_task.c
index 6df6149..f992286 100644
--- a/kernel/hung_task.c
+++ b/kernel/hung_task.c
@@ -174,8 +174,12 @@ static void check_hung_uninterruptible_tasks(unsigned long timeout)
 
 static unsigned long timeout_jiffies(unsigned long timeout)
 {
-	/* timeout of 0 will disable the watchdog */
-	return timeout ? timeout * HZ : MAX_SCHEDULE_TIMEOUT;
+	/* timeout of 0 or >= LONG_MAX/HZ will disable the watchdog */
+	if ((timeout == 0) || (timeout > MAX_SCHEDULE_TIMEOUT))
+		return MAX_SCHEDULE_TIMEOUT;
+
+	return (timeout * HZ) < MAX_SCHEDULE_TIMEOUT ?
+			timeout * HZ : MAX_SCHEDULE_TIMEOUT;
 }
 
 /*
-- 
1.9.0


             reply	other threads:[~2014-03-23  8:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-23  7:54 Liu Hua [this message]
2014-03-23 20:50 ` Satoru Takeuchi
2014-03-25  8:58   ` Liu hua
2014-03-25 16:25     ` Satoru Takeuchi
2014-03-26  7:56       ` Liu hua
2014-03-28 11:56         ` Satoru Takeuchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395561244-69173-1-git-send-email-sdu.liu@huawei.com \
    --to=sdu.liu@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mingo@kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=peifeiyue@huawei.com \
    --cc=stable@vger.kernel.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®