mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Monam Agarwal <monamagarwal123@gmail.com>
To: mathieu.desnoyers@efficios.com, rostedt@goodmis.org,
	keun-o.park@windriver.com, linux-kernel@vger.kernel.org
Subject: [PATCH] kernel: Use RCU_INIT_POINTER(x, NULL) in tracepoint.c
Date: Mon, 24 Mar 2014 00:39:08 +0530	[thread overview]
Message-ID: <1395601748-12313-1-git-send-email-monamagarwal123@gmail.com> (raw)

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure       
is carried out before storing a pointer to that structure. 
And in the case of the NULL pointer, there is no structure to initialize. 
So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
---
 kernel/tracepoint.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c
index 031cc56..72dfa96 100644
--- a/kernel/tracepoint.c
+++ b/kernel/tracepoint.c
@@ -291,7 +291,7 @@ static void disable_tracepoint(struct tracepoint *elem)
 
 	if (static_key_enabled(&elem->key))
 		static_key_slow_dec(&elem->key);
-	rcu_assign_pointer(elem->funcs, NULL);
+	RCU_INIT_POINTER(elem->funcs, NULL);
 }
 
 /**
-- 
1.7.9.5


             reply	other threads:[~2014-03-23 19:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-23 19:09 Monam Agarwal [this message]
2014-03-24 19:05 ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395601748-12313-1-git-send-email-monamagarwal123@gmail.com \
    --to=monamagarwal123@gmail.com \
    --cc=keun-o.park@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®