From: Monam Agarwal <monamagarwal123@gmail.com>
To: gleb@kernel.org, pbonzini@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] virt/kvm: Use RCU_INIT_POINTER(x, NULL) in eventfd.c
Date: Mon, 24 Mar 2014 00:54:33 +0530 [thread overview]
Message-ID: <1395602673-15753-1-git-send-email-monamagarwal123@gmail.com> (raw)
This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)
The rcu_assign_pointer() ensures that the initialization of a structure
is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize.
So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
---
virt/kvm/eventfd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c
index abe4d60..354a2af 100644
--- a/virt/kvm/eventfd.c
+++ b/virt/kvm/eventfd.c
@@ -273,7 +273,7 @@ static void irqfd_update(struct kvm *kvm, struct _irqfd *irqfd,
struct kvm_kernel_irq_routing_entry *e;
if (irqfd->gsi >= irq_rt->nr_rt_entries) {
- rcu_assign_pointer(irqfd->irq_entry, NULL);
+ RCU_INIT_POINTER(irqfd->irq_entry, NULL);
return;
}
@@ -282,7 +282,7 @@ static void irqfd_update(struct kvm *kvm, struct _irqfd *irqfd,
if (e->type == KVM_IRQ_ROUTING_MSI)
rcu_assign_pointer(irqfd->irq_entry, e);
else
- rcu_assign_pointer(irqfd->irq_entry, NULL);
+ RCU_INIT_POINTER(irqfd->irq_entry, NULL);
}
}
@@ -468,7 +468,7 @@ kvm_irqfd_deassign(struct kvm *kvm, struct kvm_irqfd *args)
* It is paired with synchronize_rcu done by caller
* of that function.
*/
- rcu_assign_pointer(irqfd->irq_entry, NULL);
+ RCU_INIT_POINTER(irqfd->irq_entry, NULL);
irqfd_deactivate(irqfd);
}
}
--
1.7.9.5
reply other threads:[~2014-03-23 19:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395602673-15753-1-git-send-email-monamagarwal123@gmail.com \
--to=monamagarwal123@gmail.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®