From: Don Zickus <dzickus@redhat.com>
To: acme@ghostprotocols.net, peterz@infradead.org
Cc: LKML <linux-kernel@vger.kernel.org>,
jolsa@redhat.com, jmario@redhat.com, fowles@inreach.com,
eranian@google.com, andi.kleen@intel.com,
Don Zickus <dzickus@redhat.com>
Subject: [PATCH 5/6] perf: Update sort to handle MAP_SHARED bits
Date: Mon, 24 Mar 2014 15:34:35 -0400 [thread overview]
Message-ID: <1395689676-214799-6-git-send-email-dzickus@redhat.com> (raw)
In-Reply-To: <1395689676-214799-1-git-send-email-dzickus@redhat.com>
Remove some of the false positives when sorting by utilizing the MAP_SHARED bit.
This helps deal with the COW cases where a virtual address is modified but is
mapped to a read-only shared library area because the perf tool doesn't understand
COW faults.
Using the MAP_SHARED bit tells the tool in this example the memory is private
and will not cause contention with other processes accessing the same shared
library area.
Signed-off-by: Don Zickus <dzickus@redhat.com>
---
tools/perf/util/sort.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index e016fc1..be675f4 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -1,3 +1,4 @@
+#include <sys/mman.h>
#include "sort.h"
#include "hist.h"
#include "comm.h"
@@ -1001,7 +1002,8 @@ sort__physid_daddr_cmp(struct hist_entry *left, struct hist_entry *right)
* assumed to be unity mapped. Sort those on address then pid.
*/
- if (l_map->maj || l_map->min || l_map->ino || l_map->ino_generation) {
+ if ((l_map->flags & MAP_SHARED) &&
+ (l_map->maj || l_map->min || l_map->ino || l_map->ino_generation)) {
/* mmapped areas */
if (l_map->maj > r_map->maj) return -1;
--
1.7.11.7
next prev parent reply other threads:[~2014-03-24 19:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 19:34 [PATCH 0/6] perf, events: Enable mmap2 support Don Zickus
2014-03-24 19:34 ` [PATCH 1/6] events, perf: Pass protection and flags bits through mmap2 interface Don Zickus
2014-03-24 19:34 ` [PATCH 2/6] perf: Update mmap2 interface with protection and flag bits Don Zickus
2014-04-09 2:17 ` Namhyung Kim
2014-04-09 2:20 ` Namhyung Kim
2014-03-24 19:34 ` [PATCH 3/6] Revert "perf: Disable PERF_RECORD_MMAP2 support" Don Zickus
2014-04-09 2:32 ` Namhyung Kim
2014-03-24 19:34 ` [PATCH 4/6] perf, sort: Add physid sorting based on mmap2 data Don Zickus
2014-03-24 19:54 ` Andi Kleen
2014-03-24 20:17 ` Don Zickus
2014-03-24 20:20 ` Andi Kleen
2014-03-24 20:26 ` Don Zickus
2014-03-24 20:54 ` [PATCH 01/15 V3] perf: Fix stddev calculation Don Zickus
2014-03-24 20:57 ` Don Zickus
2014-03-24 20:57 ` [PATCH 4/6 V2] perf, sort: Add physid sorting based on mmap2 data Don Zickus
2014-03-29 17:11 ` Jiri Olsa
2014-04-01 2:58 ` Don Zickus
2014-04-09 5:21 ` Namhyung Kim
2014-04-09 5:45 ` Peter Zijlstra
2014-04-09 3:06 ` [PATCH 4/6] " Don Zickus
2014-03-24 19:34 ` Don Zickus [this message]
2014-03-24 19:34 ` [PATCH 6/6] perf, sort: Allow unique sorting instead of combining hist_entries Don Zickus
2014-04-09 5:31 ` Namhyung Kim
2014-04-09 13:57 ` Don Zickus
2014-04-10 5:09 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395689676-214799-6-git-send-email-dzickus@redhat.com \
--to=dzickus@redhat.com \
--cc=acme@ghostprotocols.net \
--cc=andi.kleen@intel.com \
--cc=eranian@google.com \
--cc=fowles@inreach.com \
--cc=jmario@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome