From: Joe Perches <joe@perches.com>
To: Fabian Mewes <architekt@coding4coffee.org>
Cc: gregkh@linuxfoundation.org, ashvinivaratharaj@gmail.com,
cbajumpa@gmail.com, rashika.kheria@gmail.com,
berardi.dav@gmail.com, monamagarwal123@gmail.com,
lisa@xenapiadmin.com, ebru.akagunduz@gmail.com,
stefanha@gmail.com, dan.carpenter@oracle.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: line6: Fix missing blanks after declarations
Date: Mon, 24 Mar 2014 14:35:13 -0700 [thread overview]
Message-ID: <1395696913.13968.67.camel@joe-AO722> (raw)
In-Reply-To: <1395694265-2133-1-git-send-email-architekt@coding4coffee.org>
On Mon, 2014-03-24 at 21:51 +0100, Fabian Mewes wrote:
> This patch is part of eudyptula challenge task 10
>
> Signed-off-by: Fabian Mewes <architekt@coding4coffee.org>
Hi Fabian.
The patch seems fine, but please do not use something
like the above as a commit message.
It would be better to describe _why_ the change should
be done. Something like:
------
Subject: [PATCH] staging: line6: Add blank lines after declarations
Use the more common kernel coding style.
Signed-off-by: your name <your.email@domain.tld>
next prev parent reply other threads:[~2014-03-24 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 20:51 Fabian Mewes
2014-03-24 21:35 ` Joe Perches [this message]
2014-03-24 22:46 ` [PATCH v2] staging: line6: Add blank lines " Fabian Mewes
2014-03-25 8:12 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395696913.13968.67.camel@joe-AO722 \
--to=joe@perches.com \
--cc=architekt@coding4coffee.org \
--cc=ashvinivaratharaj@gmail.com \
--cc=berardi.dav@gmail.com \
--cc=cbajumpa@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=ebru.akagunduz@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lisa@xenapiadmin.com \
--cc=monamagarwal123@gmail.com \
--cc=rashika.kheria@gmail.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®