mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Romain Baeriswyl <Romain.Baeriswyl@abilis.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Rob Herring <rob.herring@calxeda.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	StephenWarren <swarren@wwwdotorg.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Rob Landley <rob@landley.net>,
	Pierrick Hascoet <pierrick.hascoet@abilis.com>,
	Vineet Gupta <vgupta@synopsys.com>,
	Christian Ruppert <christian.ruppert@abilis.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Chiau Ee Chew <chiau.ee.chew@intel.com>,
	Shinya Kuribayashi <skuribay@pobox.com>,
	Jean Delvare <khali@linux-fr.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	romainba@abilis.com,
	Romain Baeriswyl <Romain.Baeriswyl@abilis.com>
Subject: [PATCH V3 2/2] i2c designware add support of I2C standard mode
Date: Tue, 25 Mar 2014 11:18:52 +0100	[thread overview]
Message-ID: <1395742732-12155-1-git-send-email-romainba@abilis.com> (raw)
In-Reply-To: <20140309080753.GC2575@katana>

From: Romain Baeriswyl <Romain.Baeriswyl@abilis.com>

Some legacy devices support ony I2C standard mode at 100kHz.
This patch allows to select the standard mode through the DTS
with the use of the existing clock-frequency parameter.

When clock-frequency parameter is not set, the fast mode is selected.
Only when the parameter is set at 100000, the standard mode is selected.

Signed-off-by: Romain Baeriswyl <romainba@abilis.com>
Reviewed-by: Christian Ruppert <christian.ruppert@abilis.com>
---
 drivers/i2c/busses/i2c-designware-platdrv.c |   23 +++++++++++++++++++++--
 1 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index fc24399..3685893 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -122,6 +122,7 @@ static int dw_i2c_probe(struct platform_device *pdev)
 	struct i2c_adapter *adap;
 	struct resource *mem;
 	int irq, r;
+	u32 clk_freq;
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
@@ -151,6 +152,9 @@ static int dw_i2c_probe(struct platform_device *pdev)
 		return PTR_ERR(dev->clk);
 	clk_prepare_enable(dev->clk);
 
+	/* fast mode by default because of legacy reasons */
+	clk_freq = 400000;
+
 	if (pdev->dev.of_node) {
 		u32 ht = 0;
 		u32 ic_clk = dev->get_clk_rate_khz(dev);
@@ -166,6 +170,17 @@ static int dw_i2c_probe(struct platform_device *pdev)
 		of_property_read_u32(pdev->dev.of_node,
 				     "i2c-scl-falling-time-ns",
 				     &dev->scl_falling_time);
+
+		of_property_read_u32(pdev->dev.of_node, "clock-frequency",
+				     &clk_freq);
+
+		/* Only standard mode at 100kHz and fast mode at 400kHz
+		 * are supported.
+		 */
+		if (clk_freq != 100000 && clk_freq != 400000) {
+			dev_err(&pdev->dev, "Only 100kHz and 400kHz supported");
+			return -EINVAL;
+		}
 	}
 
 	dev->functionality =
@@ -175,8 +190,12 @@ static int dw_i2c_probe(struct platform_device *pdev)
 		I2C_FUNC_SMBUS_BYTE_DATA |
 		I2C_FUNC_SMBUS_WORD_DATA |
 		I2C_FUNC_SMBUS_I2C_BLOCK;
-	dev->master_cfg =  DW_IC_CON_MASTER | DW_IC_CON_SLAVE_DISABLE |
-		DW_IC_CON_RESTART_EN | DW_IC_CON_SPEED_FAST;
+	if (clk_freq == 100000)
+		dev->master_cfg =  DW_IC_CON_MASTER | DW_IC_CON_SLAVE_DISABLE |
+			DW_IC_CON_RESTART_EN | DW_IC_CON_SPEED_STD;
+	else
+		dev->master_cfg =  DW_IC_CON_MASTER | DW_IC_CON_SLAVE_DISABLE |
+			DW_IC_CON_RESTART_EN | DW_IC_CON_SPEED_FAST;
 
 	/* Try first if we can configure the device from ACPI */
 	r = dw_i2c_acpi_configure(pdev);
-- 
1.7.1


  reply	other threads:[~2014-03-25 10:48 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-08 11:45 [PATCH 1/2] i2c-designware: make *CNT values configurable Mika Westerberg
2013-07-08 11:45 ` [PATCH 2/2] i2c-designware: configure *CNT values from ACPI Mika Westerberg
2013-07-10 13:01   ` Mika Westerberg
2013-07-08 13:42 ` [PATCH 1/2] i2c-designware: make *CNT values configurable Christian Ruppert
2013-07-09  8:44   ` Mika Westerberg
2013-07-09 16:19     ` Christian Ruppert
2013-07-10 10:52       ` Mika Westerberg
2013-07-10 16:56         ` Christian Ruppert
2013-07-11  7:36           ` Mika Westerberg
2013-07-11 10:13             ` Mika Westerberg
2013-07-12  7:56               ` Shinya Kuribayashi
2013-07-12  8:51                 ` Mika Westerberg
2013-07-13  5:36                   ` Shinya Kuribayashi
2013-07-16 11:16                     ` Christian Ruppert
2013-07-17 14:39                       ` Shinya Kuribayashi
2013-07-22 13:17                         ` Christian Ruppert
2013-07-24 14:31                           ` Shinya Kuribayashi
2013-08-05  9:31                             ` Christian Ruppert
2013-08-05 10:02                               ` Wolfram Sang
2013-08-12  7:48                                 ` Christian Ruppert
2013-08-12 11:09                                   ` Wolfram Sang
2013-08-16  2:15                               ` Shinya Kuribayashi
2013-08-19 11:36                                 ` Mika Westerberg
2013-08-19 12:22                                   ` Shinya Kuribayashi
2013-08-21 14:39                                 ` Christian Ruppert
2013-08-24  4:58                                   ` Shinya Kuribayashi
2013-08-28 15:34                                     ` Christian Ruppert
2013-10-08 15:00                                       ` [PATCH 1/2] i2c designware make SCL and SDA falling time configurable Romain Baeriswyl
2013-10-09  7:55                                         ` Mika Westerberg
2013-10-10  0:54                                           ` Ryan Mallon
2013-10-13 11:36                                             ` Shinya Kuribayashi
2014-01-16 19:43                                               ` Wolfram Sang
2014-01-20 16:43                                                 ` [PATCH v2 " Romain Baeriswyl
2014-03-09  8:20                                                   ` Wolfram Sang
2013-10-08 15:00                                       ` [PATCH 2/2] i2c designware add support of I2C standard mode Romain Baeriswyl
2013-10-09  7:56                                         ` Mika Westerberg
2013-10-13 11:46                                           ` Shinya Kuribayashi
2014-01-16 19:33                                         ` Wolfram Sang
2014-01-20 16:45                                           ` [PATCH v2 " Romain Baeriswyl
2014-03-09  8:07                                             ` Wolfram Sang
2014-03-25 10:18                                               ` Romain Baeriswyl [this message]
2013-08-19  6:39                       ` [PATCH 1/2] i2c-designware: make *CNT values configurable Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395742732-12155-1-git-send-email-romainba@abilis.com \
    --to=romain.baeriswyl@abilis.com \
    --cc=chiau.ee.chew@intel.com \
    --cc=christian.ruppert@abilis.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=pawel.moll@arm.com \
    --cc=pierrick.hascoet@abilis.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=romainba@abilis.com \
    --cc=skuribay@pobox.com \
    --cc=swarren@wwwdotorg.org \
    --cc=vgupta@synopsys.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome