From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757380AbaC0WTx (ORCPT ); Thu, 27 Mar 2014 18:19:53 -0400 Received: from mail-qa0-f49.google.com ([209.85.216.49]:48367 "EHLO mail-qa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757218AbaC0WTu (ORCPT ); Thu, 27 Mar 2014 18:19:50 -0400 From: Ramkumar Ramachandra To: LKML Cc: Jiri Olsa , David Ahern , Arnaldo Carvalho de Melo Subject: [PATCH] perf stat: Don't print bogus data when one event is requested Date: Thu, 27 Mar 2014 18:20:59 -0400 Message-Id: <1395958859-14490-1-git-send-email-artagnon@gmail.com> X-Mailer: git-send-email 1.9.0.431.g014438b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When only the stalled-cycles-frontend event is requested: $ perf stat -e stalled-cycles-frontend -- git s ## acme...ram/acme Performance counter stats for 'git s': 326,947,423 stalled-cycles-frontend # 0.00% frontend cycles idle 0.363599976 seconds time elapsed The 0.00% frontend cycles idle comment in the output is totally bogus and misleading. Omit printing it here, as well as in the stalled-cycles-backend case. Cc: Jiri Olsa Cc: David Ahern Cc: Arnaldo Carvalho de Melo Signed-off-by: Ramkumar Ramachandra --- tools/perf/builtin-stat.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 8b0e1c9..0bd98fa 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -797,14 +797,13 @@ static void print_stalled_cycles_frontend(int cpu, total = avg_stats(&runtime_cycles_stats[cpu]); - if (total) + if (total) { ratio = avg / total * 100.0; - - color = get_ratio_color(GRC_STALLED_CYCLES_FE, ratio); - - fprintf(output, " # "); - color_fprintf(output, color, "%6.2f%%", ratio); - fprintf(output, " frontend cycles idle "); + color = get_ratio_color(GRC_STALLED_CYCLES_FE, ratio); + fprintf(output, " # "); + color_fprintf(output, color, "%6.2f%%", ratio); + fprintf(output, " frontend cycles idle "); + } } static void print_stalled_cycles_backend(int cpu, @@ -816,14 +815,13 @@ static void print_stalled_cycles_backend(int cpu, total = avg_stats(&runtime_cycles_stats[cpu]); - if (total) + if (total) { ratio = avg / total * 100.0; - - color = get_ratio_color(GRC_STALLED_CYCLES_BE, ratio); - - fprintf(output, " # "); - color_fprintf(output, color, "%6.2f%%", ratio); - fprintf(output, " backend cycles idle "); + color = get_ratio_color(GRC_STALLED_CYCLES_BE, ratio); + fprintf(output, " # "); + color_fprintf(output, color, "%6.2f%%", ratio); + fprintf(output, " backend cycles idle "); + } } static void print_branch_misses(int cpu, -- 1.9.0.431.g014438b