From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 413CF3557F5 for ; Tue, 27 Jan 2026 12:55:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769518543; cv=none; b=m/XetYGCrqd9mwkoJNqETXSAhsgo5FgMZpN8LltiC1+JHYGoewONrtmLenFUKeMy0FEzSa70N/Vcn0Lab6sv52MTirNi0b4Pwxz1X6LpXptHGZlt/H+fLxHtGSueZWP1NxEKfRY57SYqL+9XAYSxT8OzG0koPZLlzoW0gFhvqAg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769518543; c=relaxed/simple; bh=I5ppPJvQhXKowx/6MCJntPEB4AufpJXLqgP7Xp72MFA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RDcUr717XD2J/Xm88FkeQlX6J/1XJEsUiDkfX8UMgmZMAQG/xrsBzQYD3hMNA26kOdMjnjxlogD50iXjO3Ocn5KQoT7pdclFki2hCHYGWW4fsnAHmp6XvwaQKQ06CysRixEdlfsAvwTzrX6gtagiN7HU3NPiFYFUdXC3de7KrKE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aqi9W2iE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dSIqxOpr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aqi9W2iE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dSIqxOpr" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60RAjAOV496065 for ; Tue, 27 Jan 2026 12:55:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4XNJjHe9ozloPS1Ypr9L8/ELG3Y15mTNMRzbVUmNaw0=; b=aqi9W2iE5VvEgBIK VJKrp0Ad2F+q/XuQ1uW68ljCMAMolw1TMFq97UEAYMC+vxZyN4mHzUEW9z8y3pWY G3Nkg+Voof+5rNFReLSZhGu94vt51tACkz5qIwMH8sWrB1OXN8mGg0X1q+SgBgHk v18XVDUssxO2apPoZsu+FuTBxljVSmlnx2llFSWcZ//WEKkVwlsvUnGwR70s8mNL g9BBh5fFuhP3brGcFkJL0HMKFg8AbgXTmVu/v+qnaQTM26j2AwDYG6tuCKAFPN6S l2RVd6AyJfRaPXOMA+l9ggu/LyVA6W2OwXca54lXdwP3t8FKAaT34MWjGTjYg88g KRXddg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bxf3bjsuj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 27 Jan 2026 12:55:41 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8b2e518fb75so84325585a.3 for ; Tue, 27 Jan 2026 04:55:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769518540; x=1770123340; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4XNJjHe9ozloPS1Ypr9L8/ELG3Y15mTNMRzbVUmNaw0=; b=dSIqxOprrNoIZvYB7Fwftz86QmSTcO5onyUixWRUDgFreK5dgBIy7qfeXVipWMCwbB sT8t0zyzPkzq3ctvgXhDsQ1JQzxRveJwjjyRlDuKDulOdVW3aK86TBRTK8rBn7pYznDY hEr4GGIPbdXWfrkw0b9VXnIdwc7y44qh2N5GdqYPkfsns/29xQeU4sElKnzTWHgN1e38 nwpqsn2zsd2U1//HN7b2SYO2/GvCZPP+E5mLBPNF2rI7Bm/jameau3Y05/AIqWMYYinr oFzvXa217uozqrtSM/mYsUNI+QtquFDAJ0uEykh0kU0loxOHHY9eN1jsYvS8HBWv1+jy +eyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769518540; x=1770123340; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4XNJjHe9ozloPS1Ypr9L8/ELG3Y15mTNMRzbVUmNaw0=; b=EdMlRnmn1QiWrQlMQztOqGi+UhqeP2xRiIGvbSVEPEaNUFNXaB70MjSW58HkPDAQBZ /C1ZlGjSdeXYKS7RbjzORKveIAoP1/eDflq+IhSaDCyp8Tc5tVFEcqNQeUsSfgLUml9v XbgDEqUzpw9zXBYuk1g5pw4titbiSWbNmAqP57pbob3QK423xlOdB9nltMYaU0enAizC QUdMUahOBqsX9dUXDyzVtsCZvVP1yM/pOj9b2Ni/T+Y/J2//6G6sEfw44GeB2ZtecsWT 8tjqnXxfe6ibEdKF29pRs16PDO3/TU5LFoLHsvXeXL2vt61DN/s5gxYz9Oomh3R0cGhI mCww== X-Forwarded-Encrypted: i=1; AJvYcCUk4USwia81WVwX9fvlT0t9yhyJBZW7cAN+lTiZ3E4r6T9UpbOitbbdz52f3vdbZizOeO1fkM5ItqJz4zs=@vger.kernel.org X-Gm-Message-State: AOJu0YzuHImpYuzwN7e1rxUGkzHvsWe2fc2vVPfdoYtPQMFjug7S/kbR eO0R0YhaJjWGMaL5O2k4nINlA2FqUcKc0Oychin5vCgpJtSjL/Lv7+4iXzMqE4Sk6o6warBKt+u GT7N6LkgSpQDscGY11bKW5Z4erPdkdit/3RkcLkInBfWrI4WIdX13FpjqVNmoFW4b5dI= X-Gm-Gg: AZuq6aK6SdHD2Sm1JL9632ZsYli5wDxG7vEy28/xvoNP/WRZp0UvpYLQXmJ2gSEXWoK IIRi7+LHLkpJA+o4pisAGscigbT4I9UPo2HYe62DC8SWRFKf+aH80P0eiIt4orn6IqY0mz6kToq QR2fA6XhZkpSF2dZKNoQOK5+4EEb8taCLM6GsC4YzxdNATOcYdqLXsd2VGxGh34cpbs9/Wa26YD srqClkhZVOvOxJVMet+L+ss1fwyDvOUrJLb5SZ8YwMPacMV859rowTlSOPe9YLYRvxpPKzcqbVj NRyHTwTSy5YI3c32HG71ADzOV43OiMW1RfaYrGHCer69pu1FVpac6vIxrerDNMLIinSYgX5Lvgw 41pNpKX0OtqxbnB3sbs4vZm3q9aiBcsv/gk1sKqHcskrf6CB5oNHMd1rP4Ad1xPNVa5U= X-Received: by 2002:a05:620a:2802:b0:8c7:9e6:3a4e with SMTP id af79cd13be357-8c70b73f90cmr147769185a.0.1769518540458; Tue, 27 Jan 2026 04:55:40 -0800 (PST) X-Received: by 2002:a05:620a:2802:b0:8c7:9e6:3a4e with SMTP id af79cd13be357-8c70b73f90cmr147766685a.0.1769518539990; Tue, 27 Jan 2026 04:55:39 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b885b417339sm803576966b.22.2026.01.27.04.55.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jan 2026 04:55:29 -0800 (PST) Message-ID: <1395db8b-c31e-4c09-9b73-30c1e814d769@oss.qualcomm.com> Date: Tue, 27 Jan 2026 13:55:25 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] soc: qcom: smp2p: Add irqchip state support To: Deepak Kumar Singh , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, Chris Lew References: <20260127-smp2pv2-v3-0-4060b859b1e2@oss.qualcomm.com> <20260127-smp2pv2-v3-1-4060b859b1e2@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260127-smp2pv2-v3-1-4060b859b1e2@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: n4GiSEkTwDmbvREOIzxagsOYpuFwPebA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDEwNSBTYWx0ZWRfX5un8p7KzVkF9 Qiyz8529c5ptpAKKYEP8uXz6oJpbptcODwcVwAPqdVSRxA9PAW7wTogbGu9Fh/droJbG4YWEPp8 V0hiADpy4W0Oq30lS/sb3MaMXLfwhnCuCggx5f2wSHnsxQDUbJijjCAg+U47ncR6FNAGB6/DFdS NJ1Qt8B9vxRl11uMHON+KGDy5C135LdNjDgQgH2+EaSGrneb5DhWQxHrQx136URmxyGUdRfUJsC HgAHYfT/vOM7W33QlzH9v/lJdPazqhvHhUrXK0bH+drq4jLPh3W0RrLxsep5ZftsXz8YgsIeVez En3zF9uRN1xVVjQioFaI1F7IJwyg0OiK85sytvm6RatAa+17NbZ6v+XERb7FRwN44Thh7Sjy28b XJLmS+nwoXhPckss6d2x7awRs06wyTDApwjkzBi0LtTRXCJbXp3xeE4bfLekjuXmSKWshwcJAgc D5FpTp02i8lPtptkW4A== X-Proofpoint-GUID: n4GiSEkTwDmbvREOIzxagsOYpuFwPebA X-Authority-Analysis: v=2.4 cv=AOFXvqQI c=1 sm=1 tr=0 ts=6978b5cd cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=85DL6j0X8AjJ5NvXHg4A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-27_02,2026-01-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 spamscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601270105 On 1/27/26 11:38 AM, Deepak Kumar Singh wrote: > From: Chris Lew > > A remoteproc booted during earlier boot stages such as UEFI or the > bootloader, may need to be attached to without restarting the remoteproc > hardware. To do this the remoteproc will need to check the ready and > handover states in smp2p without an interrupt notification. Create > qcom_smp2p_start_in() to initialize the shadow state without notifying > clients because these early events happened in the past. > > Add support for the .irq_get_irqchip_state callback so remoteproc can > read the current state of the fatal, ready and handover bits. > > Signed-off-by: Chris Lew > Signed-off-by: Deepak Kumar Singh > --- > drivers/soc/qcom/smp2p.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c > index cb515c2340c1..c27ffb44b825 100644 > --- a/drivers/soc/qcom/smp2p.c > +++ b/drivers/soc/qcom/smp2p.c > @@ -222,6 +222,39 @@ static void qcom_smp2p_negotiate(struct qcom_smp2p *smp2p) > } > } > > +static void qcom_smp2p_start_in(struct qcom_smp2p *smp2p) > +{ > + unsigned int smem_id = smp2p->smem_items[SMP2P_INBOUND]; > + unsigned int pid = smp2p->remote_pid; > + char buf[SMP2P_MAX_ENTRY_NAME]; > + struct smp2p_smem_item *in; > + struct smp2p_entry *entry; > + size_t size; > + int i; > + > + in = qcom_smem_get(pid, smem_id, &size); > + if (IS_ERR(in)) > + return; > + > + smp2p->in = in; > + > + /* Check if version is initialized by the remote. */ > + if (in->version == 0) > + return; > + > + for (i = smp2p->valid_entries; i < in->valid_entries; i++) { > + list_for_each_entry(entry, &smp2p->inbound, node) { > + memcpy(buf, in->entries[i].name, sizeof(buf)); Is there a reason for this copy at all? [...] > + /* Check inbound entries in the case of early boot processor */ "in case a remote processor has already been started"? Konrad