From: Denys Vlasenko <dvlasenk@redhat.com>
To: "H. Peter Anvin" <hpa@linux.intel.com>,
Borislav Petkov <bp@suse.de>, Jacob Shin <jacob.shin@amd.com>,
Jeff Layton <jlayton@redhat.com>,
Prarit Bhargava <prarit@redhat.com>,
Mikulas Patocka <mpatocka@redhat.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-kernel@vger.kernel.org
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Subject: [PATCH 2/3] x86: microcode: report if no microcode file was found
Date: Sun, 30 Mar 2014 16:09:33 +0200 [thread overview]
Message-ID: <1396188574-2067-2-git-send-email-dvlasenk@redhat.com> (raw)
In-Reply-To: <1396188574-2067-1-git-send-email-dvlasenk@redhat.com>
Before this change, successful microcode uploads clearly
indicate that it was done:
microcode: CPU1 sig=0x206a7, pf=0x10, revision=0x1a
microcode: CPU1 updated to revision 0x29, date = 2013-06-12
whereas if microcode was not uploaded, it is not clear why:
microcode: CPU1 sig=0x206a7, pf=0x10, revision=0x29
(nothing more)
So, what was it? No microcode file? No microcode for this sig/pf?
CPU already has microcode with this (or newer) revision?
In practice, it means that I heed to ask people to provide me
with more information ("do you have microcode package installed?
which version is it?").
This change upgrades existing message from pr_debug to pr_info,
which covers "no microcode file" case:
microcode: CPU1 sig=0x206a7, pf=0x10, revision=0x29
microcode: data file intel-ucode/06-2a-07 load failed
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
---
arch/x86/kernel/cpu/microcode/intel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
index ef8b17c..9ce22b0 100644
--- a/arch/x86/kernel/cpu/microcode/intel.c
+++ b/arch/x86/kernel/cpu/microcode/intel.c
@@ -279,7 +279,7 @@ static enum ucode_state request_microcode_fw(int cpu, struct device *device,
c->x86, c->x86_model, c->x86_mask);
if (request_firmware_direct(&firmware, name, device)) {
- pr_debug("data file %s load failed\n", name);
+ pr_info("data file %s load failed\n", name);
return UCODE_NFOUND;
}
--
1.8.1.4
next prev parent reply other threads:[~2014-03-30 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-30 14:09 [PATCH 1/3] x86: microcode: report if CPU has up-to-date microcode Denys Vlasenko
2014-03-30 14:09 ` Denys Vlasenko [this message]
2014-03-31 16:26 ` [PATCH 2/3] x86: microcode: report if no microcode file was found Borislav Petkov
2014-03-30 14:09 ` [PATCH 3/3] x86: microcode: remove unused parameter and redundant variable Denys Vlasenko
2014-03-31 16:23 ` [PATCH 1/3] x86: microcode: report if CPU has up-to-date microcode Borislav Petkov
2014-03-31 17:08 ` Denys Vlasenko
2014-04-13 16:09 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396188574-2067-2-git-send-email-dvlasenk@redhat.com \
--to=dvlasenk@redhat.com \
--cc=bp@suse.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@linux.intel.com \
--cc=jacob.shin@amd.com \
--cc=jlayton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®