From: Ben Hutchings <ben@decadent.org.uk>
To: Joseph Salisbury <joseph.salisbury@canonical.com>
Cc: sfrench@samba.org, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [v3.2.y][PATCH 1/1] cifs: set MAY_SIGN when sec=krb5
Date: Sun, 30 Mar 2014 21:34:10 +0100 [thread overview]
Message-ID: <1396211650.1241.17.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <4f795fd099859c91c56b7a05996bc38a040bc9c0.1393535604.git.joseph.salisbury@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]
On Fri, 2014-02-28 at 16:07 -0500, Joseph Salisbury wrote:
> Backport from mainline commit: 0b7bc84000d71f3647ca33ab1bf5bd928535c846.
> This backport was done so including mainline commit
> 8830d7e07a5e38bc47650a7554b7c1cfd49902bf is not needed.
>
> BugLink: http://bugs.launchpad.net/bugs/1285723
>
> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
Queued up for 3.2, thanks.
Please include the original patch header in future.
Ben.
> ---
> fs/cifs/connect.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 56c152d..49d6e21 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -1113,7 +1113,8 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
> cERROR(1, "Krb5 cifs privacy not supported");
> goto cifs_parse_mount_err;
> } else if (strnicmp(value, "krb5", 4) == 0) {
> - vol->secFlg |= CIFSSEC_MAY_KRB5;
> + vol->secFlg |= CIFSSEC_MAY_KRB5 |
> + CIFSSEC_MAY_SIGN;
> } else if (strnicmp(value, "ntlmsspi", 8) == 0) {
> vol->secFlg |= CIFSSEC_MAY_NTLMSSP |
> CIFSSEC_MUST_SIGN;
--
Ben Hutchings
If more than one person is responsible for a bug, no one is at fault.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
prev parent reply other threads:[~2014-03-30 20:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 21:07 [v3.2.y][PATCH 0/1] " Joseph Salisbury
2014-02-28 21:07 ` [v3.2.y][PATCH 1/1] " Joseph Salisbury
2014-03-30 20:34 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396211650.1241.17.camel@deadeye.wl.decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=joseph.salisbury@canonical.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®