From: Denys Vlasenko <dvlasenk@redhat.com>
To: Franky Lin <frankyl@broadcom.com>,
Arend van Spriel <arend@broadcom.com>,
Hante Meuleman <meuleman@broadcom.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Subject: [PATCH 2/4] brcm80211: deinline dma64_dd_upd, save 157 bytes
Date: Sun, 30 Mar 2014 23:31:17 +0200 [thread overview]
Message-ID: <1396215079-7541-2-git-send-email-dvlasenk@redhat.com> (raw)
In-Reply-To: <1396215079-7541-1-git-send-email-dvlasenk@redhat.com>
Automated script discovered that without forced inlining,
gcc-4.7 generates smaller code for this function.
There is no need to declare static functions inline anyway:
nowadays gcc detects single-callsite static functions
which benefit from inlining.
In this case, function is large and has two callsites.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
---
drivers/net/wireless/brcm80211/brcmsmac/dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/dma.c b/drivers/net/wireless/brcm80211/brcmsmac/dma.c
index 4fb9635..5acf73e 100644
--- a/drivers/net/wireless/brcm80211/brcmsmac/dma.c
+++ b/drivers/net/wireless/brcm80211/brcmsmac/dma.c
@@ -711,7 +711,7 @@ struct dma_pub *dma_attach(char *name, struct brcms_c_info *wlc,
return NULL;
}
-static inline void
+static void
dma64_dd_upd(struct dma_info *di, struct dma64desc *ddring,
dma_addr_t pa, uint outidx, u32 *flags, u32 bufcount)
{
--
1.8.1.4
next prev parent reply other threads:[~2014-03-30 21:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-30 21:31 [PATCH 1/4] brcm80211: deinline brcmf_chip_cr4_enterdl, save 440 bytes Denys Vlasenko
2014-03-30 21:31 ` Denys Vlasenko [this message]
2014-03-30 21:31 ` [PATCH 3/4] brcm80211: deinline wlc_intstatus, save 429 bytes Denys Vlasenko
2014-03-30 21:31 ` [PATCH 4/4] brcm80211: deinline brcmf_sdio_clrintr, save 8979 bytes Denys Vlasenko
2014-03-31 7:38 ` [PATCH 1/4] brcm80211: deinline brcmf_chip_cr4_enterdl, save 440 bytes Arend van Spriel
2014-03-31 11:18 ` Denys Vlasenko
2014-03-31 11:19 ` Denys Vlasenko
2014-03-31 13:42 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396215079-7541-2-git-send-email-dvlasenk@redhat.com \
--to=dvlasenk@redhat.com \
--cc=arend@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=meuleman@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®