From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Shuduo Sang <shuduo.sang@canonical.com>,
matthew.garrett@nebula.com, ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: bruce.ma@canonical.com
Subject: Re: [PATCH V4 RESEND] Support Thinkpad X1 Carbon 2nd gen's adaptive keyboard
Date: Mon, 31 Mar 2014 14:49:49 -0300 [thread overview]
Message-ID: <1396288189.17715.101062725.0503948F@webmail.messagingengine.com> (raw)
In-Reply-To: <531EECF9.1040600@canonical.com>
On Tue, Mar 11, 2014, at 8:01, Shuduo Sang wrote:
> Resend patch V4. Support Thinkpad X1 Carbon 2nd generation's adaptive
> keyboard.
>
> Hi Henrique, could you please have a chance to review it?
I am unable to do a full review right now, but we can always adjust
minor details of the feature with later patches and the previous reviews
did help clean up the feature.
However: as far as I am concerned, this is an experimental feature until
it matures for a while. I'd rather we plug this somehow to the
thinkpad-acpi input map, for example.
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
prev parent reply other threads:[~2014-03-31 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 11:01 Shuduo Sang
2014-03-31 14:49 ` Pavel Machek
[not found] ` <CA+BAWBSqF=tL9cRm2oDb3hRMxebFV69BrgzfTbcvaGjRfKnrMw@mail.gmail.com>
2014-03-31 15:12 ` Pavel Machek
2014-03-31 17:49 ` Henrique de Moraes Holschuh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396288189.17715.101062725.0503948F@webmail.messagingengine.com \
--to=hmh@hmh.eng.br \
--cc=bruce.ma@canonical.com \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=shuduo.sang@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome