From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932131AbaDBMp0 (ORCPT ); Wed, 2 Apr 2014 08:45:26 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38163 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932071AbaDBMpY (ORCPT ); Wed, 2 Apr 2014 08:45:24 -0400 From: Takashi Iwai To: Arnd Bergmann Cc: Greg Kroah-Hartman , Struan Bartlett , Andreas Schwab , Jean Delvare , gnomes@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] ttyprintk: Fix wrong tty_unregister_driver() call in the error path Date: Wed, 2 Apr 2014 14:45:21 +0200 Message-Id: <1396442722-26346-1-git-send-email-tiwai@suse.de> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ttyprintk driver calls tty_unregister_driver() wrongly in the error path of tty_register_driver(). Also, setting ttyprintk_driver to NULL is utterly superfluous, so let's get rid of it, too. Reported-by: Jean Delvare Reviewed-by: Jean Delvare Signed-off-by: Takashi Iwai --- v1->v2: add review tag drivers/char/ttyprintk.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/char/ttyprintk.c b/drivers/char/ttyprintk.c index daea84c41743..2a39c5790364 100644 --- a/drivers/char/ttyprintk.c +++ b/drivers/char/ttyprintk.c @@ -210,10 +210,8 @@ static int __init ttyprintk_init(void) return 0; error: - tty_unregister_driver(ttyprintk_driver); put_tty_driver(ttyprintk_driver); tty_port_destroy(&tpk_port.port); - ttyprintk_driver = NULL; return ret; } device_initcall(ttyprintk_init); -- 1.9.1