From: Joe Perches <joe@perches.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: linux-efi@vger.kernel.org, matt.fleming@intel.com,
linux-kernel@vger.kernel.org, Roy Franz <roy.franz@linaro.org>
Subject: Re: [PATCH 4/5] efi: Add shared printk wrapper for consistent prefixing
Date: Fri, 04 Apr 2014 07:31:49 -0700 [thread overview]
Message-ID: <1396621909.2863.1.camel@joe-AO722> (raw)
In-Reply-To: <1396614350-20889-5-git-send-email-leif.lindholm@linaro.org>
On Fri, 2014-04-04 at 13:25 +0100, Leif Lindholm wrote:
> Add a wrapper for printk to standardize the prefix for informational and
> error messages from the EFI stub.
[]
> diff --git a/drivers/firmware/efi/efi-stub-helper.c b/drivers/firmware/efi/efi-stub-helper.c
[]
> @@ -33,6 +33,9 @@ static void efi_printk(efi_system_table_t *sys_table_arg, char *str)
[]
> +#define pr_efi(sys_table, msg) efi_printk(sys_table, "EFI stub: "msg)
> +#define pr_efi_err(sys_table, msg) efi_printk(sys_table, "EFI stub: ERROR: "msg)
[]
> @@ -486,7 +489,7 @@ static efi_status_t efi_relocate_kernel(efi_system_table_t *sys_table_arg,
> &new_addr);
> }
> if (status != EFI_SUCCESS) {
> - efi_printk(sys_table_arg, "ERROR: Failed to allocate usable memory for kernel.\n");
> + pr_efi_err(sys_table_arg, "ERROR: Failed to allocate usable memory for kernel.\n");
Author! Author! "ERROR: ERROR:"!
One too many "ERROR:" prefixes.
next prev parent reply other threads:[~2014-04-04 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 12:25 [PATCH 0/5] Non-ARM-specific EFI patches needed for ARM ports Leif Lindholm
2014-04-04 12:25 ` [PATCH 1/5] efi: efi-stub-helper cleanup Leif Lindholm
2014-04-04 12:25 ` [PATCH 2/5] efi: create memory map iteration helper Leif Lindholm
2014-04-04 12:25 ` [PATCH 3/5] efi: x86: Improve cmdline conversion Leif Lindholm
2014-04-07 13:19 ` Matt Fleming
2014-04-04 12:25 ` [PATCH 4/5] efi: Add shared printk wrapper for consistent prefixing Leif Lindholm
2014-04-04 14:31 ` Joe Perches [this message]
2014-04-04 12:25 ` [PATCH 5/5] efi: Add get_dram_base() helper function Leif Lindholm
2014-04-07 13:22 ` [PATCH 0/5] Non-ARM-specific EFI patches needed for ARM ports Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396621909.2863.1.camel@joe-AO722 \
--to=joe@perches.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=roy.franz@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®