mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: linux-media@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>,
	Eduardo Valentin <edubezval@gmail.com>,
	Mauro Carvalho Chehab <m.chehab@samsung.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Dinesh Ram <Dinesh.Ram@cern.ch>, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, Sebastian Reichel <sre@kernel.org>
Subject: [RFC 0/2] [media] si4713 DT binding
Date: Sun,  6 Apr 2014 13:52:03 +0200	[thread overview]
Message-ID: <1396785125-8759-1-git-send-email-sre@kernel.org> (raw)

Hi,

This is an RFC patch adding DT support to the si4713 radio transmitter i2c
driver. The changes can be summarized as follows:

 * Move regulator information back into the driver. The regulators needed are
   documented in the chip and have nothing to do with boarddata. Instead
   devm_regulator_get_optional and errors are handled quite loosely now.
   Maybe the USB driver should provide dummy regulators.
 * GPIO handling is updated to gpiod consumer interface, resulting in a driver
   cleanup and easy DT handling
 * The driver is updated to use managed resources wherever possible

So much about the nice stuff. But there is also

 * Instantiation of the platform device from the i2c (sub-)device. Since DT
   is not supposed to contain linuxisms the device is a simple i2c node
   resulting in the i2c probe function being called. Thus registering the main
   v4l device must happen from there.

Tested:
 * Compilation on torvalds/linux.git:master
 * Booting in DT mode
 * Some simply driver queries using v4l2-ctl

Not tested:
 * The USB driver, since I do not own the USB dongle
 * The legacy platform code (only DT boot has been tested).
   (The legacy platform code is supposed to removed in the near future anyways)

-- Sebastian

Sebastian Reichel (2):
  [media] si4713: add Device Tree support
  [media] Ad DT binding documentation for si4713

 Documentation/devicetree/bindings/media/si4713.txt |  30 ++++
 arch/arm/mach-omap2/board-rx51-peripherals.c       |  67 ++++-----
 drivers/media/radio/si4713/radio-platform-si4713.c |  28 +---
 drivers/media/radio/si4713/si4713.c                | 166 +++++++++++++--------
 drivers/media/radio/si4713/si4713.h                |  15 +-
 include/media/radio-si4713.h                       |  30 ----
 include/media/si4713.h                             |   4 +-
 7 files changed, 183 insertions(+), 157 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/si4713.txt
 delete mode 100644 include/media/radio-si4713.h

-- 
1.9.1


             reply	other threads:[~2014-04-06 11:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-06 11:52 Sebastian Reichel [this message]
2014-04-06 11:52 ` [RFC 1/2] [media] si4713: add Device Tree support Sebastian Reichel
2014-04-06 11:52 ` [RFC 2/2] [media] Ad DT binding documentation for si4713 Sebastian Reichel
2014-04-28 14:15 ` [RFC 0/2] [media] si4713 DT binding Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396785125-8759-1-git-send-email-sre@kernel.org \
    --to=sre@kernel.org \
    --cc=Dinesh.Ram@cern.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=edubezval@gmail.com \
    --cc=galak@codeaurora.org \
    --cc=hans.verkuil@cisco.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome