Re: [PATCH v2 4/5] Staging: rts5139: pr_warn(...) in place of printk(KERN_WARNING ...)

[Joe Perches <joe@perches.com>]

On Mon, 2014-04-07 at 22:27 +0200, Fabio Falzoi wrote:
> All printk(KERN_WARNING ...) replaced with pr_warn(...).

Please remove the RTS51X_TIP prefix and and and use

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

before any #include so that pr_<level> uses
are prefixed in a standard way.

> diff --git a/drivers/staging/rts5139/rts51x.c b/drivers/staging/rts5139/rts51x.c
[]
> @@ -725,8 +725,8 @@ static int rts51x_probe(struct usb_interface *intf,
>  
>  	rts51x = kzalloc(sizeof(struct rts51x_usb), GFP_KERNEL);
>  	if (!rts51x) {
> -		printk(KERN_WARNING RTS51X_TIP
> -		       "Unable to allocate rts51x_usb\n");
> +		pr_warn(RTS51X_TIP
> +			"Unable to allocate rts51x_usb\n");

This could be deleted.

alloc OOM messages aren't necessary as there's a generic
OOM message with a dump_stack() already done.

> @@ -736,8 +736,8 @@ static int rts51x_probe(struct usb_interface *intf,
>  	 */
>  	host = scsi_host_alloc(&rts51x_host_template, sizeof(*chip));
>  	if (!host) {
> -		printk(KERN_WARNING RTS51X_TIP
> -		       "Unable to allocate the scsi host\n");
> +		pr_warn(RTS51X_TIP
> +			"Unable to allocate the scsi host\n");

This could be on a single line

		pr_warn("Unable to allocate the scsi host\n");

> @@ -778,8 +778,8 @@ static int rts51x_probe(struct usb_interface *intf,
>  	/* Start up our control thread */
>  	th = kthread_run(rts51x_control_thread, chip, RTS51X_CTL_THREAD);
>  	if (IS_ERR(th)) {
> -		printk(KERN_WARNING RTS51X_TIP
> -		       "Unable to start control thread\n");
> +		pr_warn(RTS51X_TIP
> +			"Unable to start control thread\n");

single line, etc.