From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] sched: update_rq_clock() must skip ONE update
Date: Tue, 08 Apr 2014 18:56:02 +0200 [thread overview]
Message-ID: <1396976162.4613.15.camel@marge.simpson.net> (raw)
In-Reply-To: <20140408155311.GP11096@twins.programming.kicks-ass.net>
On Tue, 2014-04-08 at 17:53 +0200, Peter Zijlstra wrote:
> OK; so as previously mentioned (Oct '13); I've entirely had it with
> skip_clock_update bugs, so I got angry and did the below.
Goody, kick butt take names ;-)
> Its not something I can merge, not least because it uses trace_printk(),
> but it should be usable to 1) demonstate the above actually helps and 2)
> make damn sure we got it right this time :-)
That would be nice, little cycle savers like this aren't supposed to
have nasty corner cases that can clean your clock (pun intended).
> I've not really stared at the output much yet; but when you select
> function_graph tracer; we get lovely things like:
I'll plug it into my quilt pile.
-Mike
prev parent reply other threads:[~2014-04-08 16:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-30 7:24 Mike Galbraith
2014-03-31 0:12 ` Linus Torvalds
2014-03-31 4:20 ` Mike Galbraith
2014-03-31 16:00 ` Steven Rostedt
2014-04-01 3:10 ` Mike Galbraith
2014-04-01 3:26 ` Steven Rostedt
2014-03-31 16:13 ` Linus Torvalds
2014-03-31 18:27 ` Mike Galbraith
2014-03-31 18:37 ` Linus Torvalds
2014-04-01 3:28 ` Mike Galbraith
2014-04-01 9:55 ` Ingo Molnar
2014-04-03 8:02 ` Mike Galbraith
2014-04-08 15:53 ` Peter Zijlstra
2014-04-08 16:56 ` Mike Galbraith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396976162.4613.15.camel@marge.simpson.net \
--to=umgwanakikbuti@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®