From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0D4D3DA5A0; Wed, 4 Mar 2026 18:17:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772648236; cv=none; b=tZnJNd5OxFlIxOOIVg9KbpPfIoscqXx9iKpuIPWhwXKgasT+rLQen1HCcapBSs7F6uZc8MDOq3ZkqNyPAIMsxQ6BpMdtucLLJuavzsAn2mHsmFgZ2qQdZEmX/nkVOXOtMFIoEy2X7es8MmQMGhLTUodZ+4JhrqEbjhnJTIn4JGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772648236; c=relaxed/simple; bh=9GoprUYSUZssZ1PQaBB39NYf3vii5X9keDoAbe8U6Nk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=i+IVfWicohIGPoeZvXCKvPkQn+xtuG7OGTsamZE1CXCILt69Y6b/K1Kwq4ZNcX+q5RX06hUbnHfuNszxIoX92rPJSe9Qm2bTxceBYkJlE25flF3srD75j2OcKTy2UjA2i7z7gQllLJGD/twWrBn6+IuPkeBMIu6S27VIQxiGXDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DGS+T7jE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DGS+T7jE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41AA2C19425; Wed, 4 Mar 2026 18:17:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772648236; bh=9GoprUYSUZssZ1PQaBB39NYf3vii5X9keDoAbe8U6Nk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DGS+T7jEcTI8Be2G2lD/3RTtYDyJSp3vsWY7cU6obHXHU3W9sEA4r3xkZhijR4mEX gtGxDuZ7Cz2Di8+7XdHJlp7eLhP8dtKn4n9Um374xMTfJgbeMo6sAc3V+1YNUt9TiI lgVvmBPi6jPXKeJ5j0C/kCSUuxXPFggtSKsb+ywM/EmM5oTaA+cMkjDxvpOQqvb8a/ uwYiMVRgM4R4pvLNpqFFBqTjw2OSDx8hCa12qUGoIExhiOtyzvUU+mrw6aXdK3+pTR FLot7dtIMpr5wlLT8r1OR+q1o5MUkDvkb3xyleXy02VteaGVPruNtZo3VFX6JvSQKz i709I89LSKhPQ== From: "Rafael J. Wysocki" To: Linux ACPI Cc: Alexandre Belloni , LKML , linux-rtc@vger.kernel.org, Linux PM Subject: [PATCH v1 3/7] ACPI: TAD: Use __free() for cleanup in time_store() Date: Wed, 04 Mar 2026 19:14:01 +0100 Message-ID: <13971300.uLZWGnKmhe@rafael.j.wysocki> Organization: Linux Kernel Development In-Reply-To: <5092662.31r3eYUQgx@rafael.j.wysocki> References: <5092662.31r3eYUQgx@rafael.j.wysocki> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" From: Rafael J. Wysocki Use __free() for the automatic freeing of memory pointed to by local variable str in time_store() which allows the code to become somewhat easier to follow. No intentional functional impact. Signed-off-by: Rafael J. Wysocki --- drivers/acpi/acpi_tad.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) --- a/drivers/acpi/acpi_tad.c +++ b/drivers/acpi/acpi_tad.c @@ -167,57 +167,57 @@ static ssize_t time_store(struct device const char *buf, size_t count) { struct acpi_tad_rt rt; - char *str, *s; - int val, ret = -ENODATA; + int val, ret; + char *s; - str = kmemdup_nul(buf, count, GFP_KERNEL); + char *str __free(kfree) = kmemdup_nul(buf, count, GFP_KERNEL); if (!str) return -ENOMEM; s = acpi_tad_rt_next_field(str, &val); if (!s) - goto out_free; + return -ENODATA; rt.year = val; s = acpi_tad_rt_next_field(s, &val); if (!s) - goto out_free; + return -ENODATA; rt.month = val; s = acpi_tad_rt_next_field(s, &val); if (!s) - goto out_free; + return -ENODATA; rt.day = val; s = acpi_tad_rt_next_field(s, &val); if (!s) - goto out_free; + return -ENODATA; rt.hour = val; s = acpi_tad_rt_next_field(s, &val); if (!s) - goto out_free; + return -ENODATA; rt.minute = val; s = acpi_tad_rt_next_field(s, &val); if (!s) - goto out_free; + return -ENODATA; rt.second = val; s = acpi_tad_rt_next_field(s, &val); if (!s) - goto out_free; + return -ENODATA; rt.tz = val; if (kstrtoint(s, 10, &val)) - goto out_free; + return -ENODATA; rt.daylight = val; @@ -226,10 +226,10 @@ static ssize_t time_store(struct device memset(rt.padding, 0, 3); ret = acpi_tad_set_real_time(dev, &rt); + if (ret) + return ret; -out_free: - kfree(str); - return ret ? ret : count; + return count; } static ssize_t time_show(struct device *dev, struct device_attribute *attr,