From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754423AbaDKRej (ORCPT ); Fri, 11 Apr 2014 13:34:39 -0400 Received: from smtprelay0071.hostedemail.com ([216.40.44.71]:41909 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754323AbaDKReh (ORCPT ); Fri, 11 Apr 2014 13:34:37 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:973:988:989:1260:1261:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:4250:4321:5007:7652:10004:10400:10848:11026:11232:11473:11658:11914:12296:12517:12519:12740:13069:13311:13357,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: humor06_623aabcf05347 X-Filterd-Recvd-Size: 1920 Message-ID: <1397237673.7113.22.camel@joe-AO722> Subject: Re: [PATCH 1/3] sched,numa: count pages on active node as local From: Joe Perches To: riel@redhat.com Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, peterz@infradead.org, chegu_vinod@hp.com, mgorman@suse.de Date: Fri, 11 Apr 2014 10:34:33 -0700 In-Reply-To: <1397235629-16328-2-git-send-email-riel@redhat.com> References: <1397235629-16328-1-git-send-email-riel@redhat.com> <1397235629-16328-2-git-send-email-riel@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.8.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2014-04-11 at 13:00 -0400, riel@redhat.com wrote: > This should reduce the overhead of the automatic NUMA placement > code, when a workload spans multiple NUMA nodes. trivial style note: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c [] > @@ -1737,6 +1737,7 @@ void task_numa_fault(int last_cpupid, int mem_node, int pages, int flags) > struct task_struct *p = current; > bool migrated = flags & TNF_MIGRATED; > int cpu_node = task_node(current); > + int local = !!(flags & TNF_FAULT_LOCAL); Perhaps local would look nicer as bool and be better placed next to migrated. bool migrated = flags & TNF_MIGRATED; bool local = flags & TNF_FAULT_LOCAL; int cpu_node = task_node(current); > @@ -1785,6 +1786,17 @@ void task_numa_fault(int last_cpupid, int mem_node, int pages, int flags) > + if (!priv && !local && p->numa_group && > + node_isset(cpu_node, p->numa_group->active_nodes) && > + node_isset(mem_node, p->numa_group->active_nodes)) > + local = 1; local = true;