From: Joe Perches <joe@perches.com>
To: Rik van Riel <riel@redhat.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
peterz@infradead.org, chegu_vinod@hp.com, mgorman@suse.de
Subject: Re: [PATCH 1/3] sched,numa: count pages on active node as local
Date: Fri, 11 Apr 2014 11:01:50 -0700 [thread overview]
Message-ID: <1397239310.7113.35.camel@joe-AO722> (raw)
In-Reply-To: <53482953.3070201@redhat.com>
On Fri, 2014-04-11 at 13:41 -0400, Rik van Riel wrote:
> On 04/11/2014 01:34 PM, Joe Perches wrote:
> > On Fri, 2014-04-11 at 13:00 -0400, riel@redhat.com wrote:
> >> This should reduce the overhead of the automatic NUMA placement
> >> code, when a workload spans multiple NUMA nodes.
[]
> > Perhaps local would look nicer as bool
> > and be better placed next to migrated.
>
> The problem is, at the end of the function, local is used as an
> array index...
Oh, thanks.
> p->numa_faults_locality[local] += pages;
>
> I'm not sure I really want to use a bool as an array index :)
Nor I particularly but using bool as an array index is
already done in at least kernel/workqueue.c and
kernel/trace/blktrace.c
Doesn't make it right of course.
next prev parent reply other threads:[~2014-04-11 18:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 17:00 [PATCH 0/3] sched,numa: reduce page migrations with pseudo-interleaving riel
2014-04-11 17:00 ` [PATCH 1/3] sched,numa: count pages on active node as local riel
2014-04-11 17:34 ` Joe Perches
2014-04-11 17:41 ` Rik van Riel
2014-04-11 18:01 ` Joe Perches [this message]
2014-04-25 9:04 ` Mel Gorman
2014-05-08 10:42 ` [tip:sched/core] sched/numa: Count " tip-bot for Rik van Riel
2014-04-11 17:00 ` [PATCH 2/3] sched,numa: retry placement more frequently when misplaced riel
2014-04-11 17:46 ` Joe Perches
2014-04-11 18:03 ` Rik van Riel
2014-04-14 8:19 ` Ingo Molnar
2014-04-25 9:05 ` Mel Gorman
2014-05-08 10:42 ` [tip:sched/core] sched/numa: Retry " tip-bot for Rik van Riel
2014-04-11 17:00 ` [PATCH 3/3] sched,numa: do not set preferred_node on migration to a second choice node riel
2014-04-14 12:56 ` Peter Zijlstra
2014-04-15 14:35 ` Rik van Riel
2014-04-15 16:51 ` Peter Zijlstra
2014-04-25 9:09 ` Mel Gorman
2014-05-08 10:43 ` [tip:sched/core] sched/numa: Do " tip-bot for Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397239310.7113.35.camel@joe-AO722 \
--to=joe@perches.com \
--cc=chegu_vinod@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®