From: Oliver Neukum <oliver@neukum.org>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: Re: [PATCH] USB: cdc-acm: fix double usb_autopm_put_interface() in acm_port_activate()
Date: Sat, 12 Apr 2014 20:39:00 +0200 [thread overview]
Message-ID: <1397327940.4810.4.camel@linux-fkkt.site> (raw)
In-Reply-To: <1397254245-7498-1-git-send-email-khoroshilov@ispras.ru>
On Sat, 2014-04-12 at 02:10 +0400, Alexey Khoroshilov wrote:
> If acm_submit_read_urbs() fails in acm_port_activate(), error handling
> code calls usb_autopm_put_interface() while it is already called
> before acm_submit_read_urbs(). The patch reorganizes error handling code
> to avoid double decrement of USB interface's PM-usage counter.
>
> Found by Linux Driver Verification project (linuxtesting.org).
Nice catch.
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Acked-by: Oliver Neukum <oliver@neukum.org>
prev parent reply other threads:[~2014-04-12 18:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 22:10 Alexey Khoroshilov
2014-04-12 18:39 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397327940.4810.4.camel@linux-fkkt.site \
--to=oliver@neukum.org \
--cc=gregkh@linuxfoundation.org \
--cc=khoroshilov@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®