From: Joe Perches <joe@perches.com>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] kernel/rcu/tree.c: remove duplicate extern definition
Date: Sun, 13 Apr 2014 20:18:00 -0700 [thread overview]
Message-ID: <1397445480.5243.6.camel@joe-AO722> (raw)
In-Reply-To: <CAJhHMCBsa6ypbaLZ2Uv6x60uU-xq=veAem85Ke=-R+nbW5=5fA@mail.gmail.com>
On Sun, 2014-04-13 at 23:03 -0400, Pranith Kumar wrote:
> On Sun, Apr 13, 2014 at 10:50 PM, Joe Perches <joe@perches.com> wrote:
> >> -/*
> >> - * This function really isn't for public consumption, but RCU is special in
> >> - * that context switches can allow the state machine to make progress.
> >> - */
> >> -extern void resched_cpu(int cpu);
> >
> > why not #include "sched.h"
> > and remove both declarations?
> As the comment mentions, resched_cpu is internal to the scheduler and
> hence is in sched/sched.h file and not in linux/sched.h.
Note the use of quotes and lack of angle brackets.
> sched/sched.h cannot be included in other subsystems directly.
If functions from it can be declared extern,
then likely it could be used in an #include.
next prev parent reply other threads:[~2014-04-14 3:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAJhHMCCE0QHvzqrdY-w8bB8ZK=JRN02V29XwaFYRXmu=9RhG9Q@mail.gmail.com>
2014-04-14 1:39 ` Pranith Kumar
2014-04-14 2:50 ` Joe Perches
2014-04-14 3:03 ` Pranith Kumar
2014-04-14 3:18 ` Joe Perches [this message]
2014-04-14 3:31 ` Pranith Kumar
[not found] <CAJhHMCBVQTpDecjd5sVhCWJk++K_Rne0DfHRoF7aSd7SRYp1WA@mail.gmail.com>
2014-04-14 16:07 ` Paul E. McKenney
2014-04-14 16:19 ` Pranith Kumar
2014-04-14 16:27 ` Pranith Kumar
2014-04-14 17:31 ` Paul E. McKenney
2014-04-14 16:32 ` Paul E. McKenney
2014-04-14 16:53 ` Joe Perches
2014-04-14 17:17 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397445480.5243.6.camel@joe-AO722 \
--to=joe@perches.com \
--cc=bobby.prani@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®