From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <dan.j.williams@intel.com>, <vinod.koul@intel.com>,
<nsekhar@ti.com>, <joelf@ti.com>
Cc: <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>,
<davinci-linux-open-source@linux.davincidsp.com>
Subject: [PATCH v3 08/10] dmaengine: edma: Prefix debug prints where the text were identical in prep callbacks
Date: Mon, 14 Apr 2014 14:42:03 +0300 [thread overview]
Message-ID: <1397475725-5036-9-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1397475725-5036-1-git-send-email-peter.ujfalusi@ti.com>
prep_slave_sg and prep_dma_cyclic callbacks have mostly same failure cases
with the same texts printed in case we hit them. It helps when debugging if
we know exactly which callback generated the errors.
At the same time change the debug level for descriptor allocation failure
from dbg to err since all other error cases are dev_err and this failure is
similarly fatal as the other ones.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Joel Fernandes <joelf@ti.com>
---
drivers/dma/edma.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index 6d9edc47150d..bc8175c92e0c 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -436,14 +436,14 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg(
}
if (dev_width == DMA_SLAVE_BUSWIDTH_UNDEFINED) {
- dev_err(dev, "Undefined slave buswidth\n");
+ dev_err(dev, "%s: Undefined slave buswidth\n", __func__);
return NULL;
}
edesc = kzalloc(sizeof(*edesc) + sg_len *
sizeof(edesc->pset[0]), GFP_ATOMIC);
if (!edesc) {
- dev_dbg(dev, "Failed to allocate a descriptor\n");
+ dev_err(dev, "%s: Failed to allocate a descriptor\n", __func__);
return NULL;
}
@@ -459,7 +459,8 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg(
EDMA_SLOT_ANY);
if (echan->slot[i] < 0) {
kfree(edesc);
- dev_err(dev, "Failed to allocate slot\n");
+ dev_err(dev, "%s: Failed to allocate slot\n",
+ __func__);
return NULL;
}
}
@@ -528,7 +529,7 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic(
}
if (dev_width == DMA_SLAVE_BUSWIDTH_UNDEFINED) {
- dev_err(dev, "Undefined slave buswidth\n");
+ dev_err(dev, "%s: Undefined slave buswidth\n", __func__);
return NULL;
}
@@ -553,7 +554,7 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic(
edesc = kzalloc(sizeof(*edesc) + nslots *
sizeof(edesc->pset[0]), GFP_ATOMIC);
if (!edesc) {
- dev_dbg(dev, "Failed to allocate a descriptor\n");
+ dev_err(dev, "%s: Failed to allocate a descriptor\n", __func__);
return NULL;
}
@@ -571,7 +572,8 @@ static struct dma_async_tx_descriptor *edma_prep_dma_cyclic(
EDMA_SLOT_ANY);
if (echan->slot[i] < 0) {
kfree(edesc);
- dev_err(dev, "Failed to allocate slot\n");
+ dev_err(dev, "%s: Failed to allocate slot\n",
+ __func__);
return NULL;
}
}
--
1.9.2
next prev parent reply other threads:[~2014-04-14 11:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 11:41 [PATCH v3 00/10] dma: edma: Fixes for cyclic (audio) operation Peter Ujfalusi
2014-04-14 11:41 ` [PATCH v3 01/10] platform_data: edma: Be precise with the paRAM struct Peter Ujfalusi
2014-05-26 21:32 ` Olof Johansson
2014-05-27 10:22 ` Peter Ujfalusi
2014-05-27 15:03 ` Joel Fernandes
2014-05-28 10:31 ` Peter Ujfalusi
2014-04-14 11:41 ` [PATCH v3 02/10] arm: common: edma: Save the number of event queues/TCs Peter Ujfalusi
2014-04-14 11:41 ` [PATCH v3 03/10] dmaengine: edma: Correct the handling of src/dst_maxburst == 0 Peter Ujfalusi
2014-04-14 11:41 ` [PATCH v3 04/10] dmaengine: edma: Add support for DMA_PAUSE/RESUME operation Peter Ujfalusi
2014-04-14 11:42 ` [PATCH v3 05/10] dmaengine: edma: Set DMA_CYCLIC capability flag Peter Ujfalusi
2014-04-14 11:42 ` [PATCH v3 06/10] dmaengine: edma: Implement device_slave_caps callback Peter Ujfalusi
2014-04-14 11:42 ` [PATCH v3 07/10] dmaengine: edma: Reduce debug print verbosity for non verbose debugging Peter Ujfalusi
2014-04-14 11:42 ` Peter Ujfalusi [this message]
2014-04-14 11:42 ` [PATCH v3 09/10] dmaengine: edma: Add channel number to debug prints Peter Ujfalusi
2014-04-22 16:02 ` Vinod Koul
2014-04-14 11:42 ` [PATCH v3 10/10] dmaengine: edma: Print the direction value as well when it is not supported Peter Ujfalusi
2014-04-16 18:11 ` [PATCH v3 00/10] dma: edma: Fixes for cyclic (audio) operation Joel Fernandes
2014-04-21 16:54 ` Joel Fernandes
2014-04-22 16:03 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397475725-5036-9-git-send-email-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=dan.j.williams@intel.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=dmaengine@vger.kernel.org \
--cc=joelf@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®