From: Joe Perches <joe@perches.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Bjorn <bhelgaas@google.com>, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/1] Drivers/PCI: Logging clean-up [1]
Date: Tue, 15 Apr 2014 13:06:45 -0700 [thread overview]
Message-ID: <1397592405.8998.6.camel@joe-AO722> (raw)
In-Reply-To: <20140415205552.e358a533cf0632026f6bd342@skynet.be>
On Tue, 2014-04-15 at 20:55 +0200, Fabian Frederick wrote:
> diff --git a/drivers/pci/pci-stub.c b/drivers/pci/pci-stub.c
[]
> @@ -15,7 +15,7 @@
> * # ls -l /sys/bus/pci/devices/0000:00:19.0/driver
> * .../0000:00:19.0/driver -> ../../../bus/pci/drivers/pci-stub
> */
> -
> +#define pr_fmt(fmt) "pci-stub: " fmt
When the output prefix matches the module/filename, please use
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
[]
> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
[]
> @@ -903,8 +903,8 @@ legacy_io_err:
> kfree(b->legacy_io);
> b->legacy_io = NULL;
> kzalloc_err:
> - printk(KERN_WARNING "pci: warning: could not create legacy I/O port "
> - "and ISA memory resources to sysfs\n");
> + pr_warn("warning: could not create legacy I/O port "
> + "and ISA memory resources to sysfs\n");
Please coalesce format fragments too even if the format part
exceeds 80 columns.
prev parent reply other threads:[~2014-04-15 20:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 18:55 Fabian Frederick
2014-04-15 20:06 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397592405.8998.6.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®