From: Joe Perches <joe@perches.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
akpm <akpm@linux-foundation.org>, Bjorn <bhelgaas@google.com>
Subject: Re: [PATCH v2] Drivers/PCI: Logging clean-up [1]
Date: Tue, 15 Apr 2014 22:41:15 -0700 [thread overview]
Message-ID: <1397626875.15177.3.camel@joe-AO722> (raw)
In-Reply-To: <20140416073736.8ae3ea7cd0f94f0e056fca84@skynet.be>
On Wed, 2014-04-16 at 07:37 +0200, Fabian Frederick wrote:
> -Convert printk(KERN_WARNING|KERN_ERR|KERN_INFO to pr_foo()
> -Define pr_fmt where it doesn't break existing format.
[]
> (other ones ?)
[]
> diff --git a/drivers/pci/hotplug/cpqphp_core.c b/drivers/pci/hotplug/cpqphp_core.c
[]
> @@ -830,8 +831,8 @@ static int cpqhpc_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>
> err = pci_enable_device(pdev);
> if (err) {
> - printk(KERN_ERR MY_NAME ": cannot enable PCI device %s (%d)\n",
> - pci_name(pdev), err);
> + pr_err("cannot enable PCI device %s (%d)\n", pci_name(pdev),
> + err);
trivia:
My preference is to keep format and argument
on a single line where possible and on
separate lines when not.
pr_err("cannot enable PCI device %s (%d)\n",
pci_name(pdev), err);
prev parent reply other threads:[~2014-04-16 5:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 5:37 Fabian Frederick
2014-04-16 5:41 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397626875.15177.3.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®