From: Joe Perches <joe@perches.com>
To: Seunghun Lee <waydi1@gmail.com>, John Stultz <john.stultz@linaro.org>
Cc: greg@kroah.com, swetland@google.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging : android : uapi : fix coding style
Date: Wed, 16 Apr 2014 07:39:50 -0700 [thread overview]
Message-ID: <1397659190.32088.4.camel@joe-AO722> (raw)
In-Reply-To: <1397658459-4357-1-git-send-email-waydi1@gmail.com>
(adding John Stultz)
On Wed, 2014-04-16 at 23:27 +0900, Seunghun Lee wrote:
> This patch fix checkpatch.pl warnings and errors.
[]
> diff --git a/drivers/staging/android/uapi/binder.h b/drivers/staging/android/uapi/binder.h
[]
> @@ -169,7 +169,7 @@ struct binder_ptr_cookie {
> struct binder_handle_cookie {
> __u32 handle;
> binder_uintptr_t cookie;
> -} __attribute__((packed));
> +} __packed;
If this .h file is meant to be a user-space #include,
then it should not use the kernel specific __packed
but keep the __attribute__((packed))
It does use __u32 though and that's generally
kernel specific.
John? Does any of these binder uapi files need a
bit more sorting out?
next prev parent reply other threads:[~2014-04-16 14:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 14:27 Seunghun Lee
2014-04-16 14:39 ` Joe Perches [this message]
2014-04-16 16:36 ` John Stultz
2014-04-16 16:54 ` Colin Cross
2014-04-16 14:44 ` Dan Carpenter
2014-04-16 15:27 ` earl
2014-04-16 15:39 [PATCH] staging: android: uapi: " Seunghun Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397659190.32088.4.camel@joe-AO722 \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swetland@google.com \
--cc=waydi1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®