mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: frowand.list@gmail.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [DRIVER CORE] drivers/base/dd.c incorrect pr_debug() parameters
Date: Wed, 16 Apr 2014 18:23:05 -0700	[thread overview]
Message-ID: <1397697785.4603.6.camel@joe-AO725> (raw)
In-Reply-To: <534F2A88.8050408@gmail.com>

On Wed, 2014-04-16 at 18:12 -0700, Frank Rowand wrote:
> On 4/16/2014 5:48 PM, Joe Perches wrote:
> > On Wed, 2014-04-16 at 17:12 -0700, Frank Rowand wrote:
> >> pr_debug() parameters are reverse order of format string
> > 
> > Another way to do this might be to change all the
> > printks/pr_debugs to dev_<level>
> 
> Yes, but if that is done, one may as well do all of drivers/base/*.c
> and drivers/base/*/*.c

Actually, I don't think so, no.

These are the ones that have a struct device attached
to them.  Many of the others are device free and are
prefixed differently, like power and devtmpfs and bus.

> I was only trying to fix incorrectly reported information from one
> pr_debug().  If someone else want to do a big conversion, they are
> free to.  :-)

Always true...

cheers, Joe


  reply	other threads:[~2014-04-17  1:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-17  0:12 Frank Rowand
2014-04-17  0:48 ` Joe Perches
2014-04-17  1:12   ` Frank Rowand
2014-04-17  1:23     ` Joe Perches [this message]
2014-04-17  2:34 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397697785.4603.6.camel@joe-AO725 \
    --to=joe@perches.com \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®