mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ming Lei <tom.leiming@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>, Ming Lei <tom.leiming@gmail.com>
Subject: [PATCH v1 next 1/4] blk-mq: free hctx->ctx_map when init failed
Date: Sat, 19 Apr 2014 18:00:16 +0800	[thread overview]
Message-ID: <1397901619-27226-2-git-send-email-tom.leiming@gmail.com> (raw)
In-Reply-To: <1397901619-27226-1-git-send-email-tom.leiming@gmail.com>

Avoid memory leak in the failure path.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
 block/blk-mq.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index ee225cc..5fbbb22 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1289,6 +1289,7 @@ static int blk_mq_init_hw_queues(struct request_queue *q,
 
 		blk_mq_unregister_cpu_notifier(&hctx->cpu_notifier);
 		kfree(hctx->ctxs);
+		kfree(hctx->ctx_map);
 	}
 
 	return 1;
-- 
1.7.9.5


  reply	other threads:[~2014-04-19 10:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-19 10:00 [PATCH v1 next 0/4] blk-mq: misc changes Ming Lei
2014-04-19 10:00 ` Ming Lei [this message]
2014-04-19 10:00 ` [PATCH v1 next 2/4] blk-mq: fix allocation of set->tags Ming Lei
2014-04-19 10:00 ` [PATCH v1 next 3/4] blk-mq: user (1 << order) to implement order_to_size() Ming Lei
2014-04-19 10:00 ` [PATCH v1 next 4/4] blk-mq: initialize req->q in allocation Ming Lei
2014-04-22  1:03 ` [PATCH v1 next 0/4] blk-mq: misc changes Jens Axboe
2014-04-22  1:25   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397901619-27226-2-git-send-email-tom.leiming@gmail.com \
    --to=tom.leiming@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®